From 71e9a7f70dce1b338a2cf3040fb17962eceb11fd Mon Sep 17 00:00:00 2001 From: Fran Iruela Date: Tue, 14 Dec 2021 15:34:21 +0100 Subject: [PATCH 1/3] Replace 'errors' with expected 'api_error_response' --- lib/braintree/plan_gateway.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/braintree/plan_gateway.rb b/lib/braintree/plan_gateway.rb index 0b4d84ab..ee3f1e8a 100644 --- a/lib/braintree/plan_gateway.rb +++ b/lib/braintree/plan_gateway.rb @@ -106,10 +106,10 @@ def _do_create(path, params) # :nodoc: response = @config.http.post("#{@config.base_merchant_path}#{path}", params) if response[:plan] SuccessfulResult.new(:plan => Plan._new(@gateway, response[:plan])) - elsif response[:errors] - ErrorResult.new(@gateway, response[:errors]) + elsif response[:api_error_response] + ErrorResult.new(@gateway, response[:api_error_response]) else - raise UnexpectedError, "expected :plan or :errors" + raise UnexpectedError, "expected :plan or :api_error_response" end end end From 283d4adfb96f56c0b8609edaaa95d75335a1572c Mon Sep 17 00:00:00 2001 From: Fran Iruela Date: Tue, 14 Dec 2021 15:46:26 +0100 Subject: [PATCH 2/3] Update Changelog with last issue fixed --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ca4d9b13..d6fe5eb5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +# Unreleased + +* Fix issue #223: Replace 'errors' with expected 'api_error_response' + # Changelog ## 4.5.0 From 9b08137abdceb6f67bdd09251fdcbaaa6ced5fb3 Mon Sep 17 00:00:00 2001 From: Dani <58542682+DPoplin@users.noreply.github.com> Date: Fri, 16 Sep 2022 10:56:15 -0500 Subject: [PATCH 3/3] Update CHANGELOG.md Co-authored-by: Blade Barringer --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6fe5eb5..c9c11f4c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,8 @@ -# Unreleased +# Changelog -* Fix issue #223: Replace 'errors' with expected 'api_error_response' +## Unreleased -# Changelog +* Fix issue where validation errors from creating a plan were not surfaced (#223) ## 4.5.0 * Add plan create/update/find API endpoint