1513 dynamic resizing labels #2345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| }); | ||
|
|
||
| function getTextHeightForTextAnnotation(event) { | ||
| return event.gfx.firstChild.lastChild.lastChild.y.animVal[0].value; |
There was a problem hiding this comment.
I'm not sure how to make this look nicer. If you know another way, please show me with a pointer.
|
Hi, thanks for your contribution. We will look into this soon. |
nikku
requested review from
a team,
barmac and
philippfromme
and removed request for
a team
|
Some interactions don't work properly or are not intuitive, so there's still some work ahead. I'd expect that the horizontal resize snaps to the text width. The label jump on vertical resize is also unintuitive. Screen.Recording.2025-09-10.at.11.43.31.mov |
barmac
requested changes
Sep 10, 2025
philippfromme
force-pushed
the
develop
branch
from
d604e3b to
ec9aa3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request concerns dynamic resizing of text fields. To this end, labels have been made resizable and code has been added that adjusts the height of the text to match the width.
Closes #1513
Visual demo
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}