next-api-change

Signed-off-by: Andreas Karis <[email protected]>

next

Signed-off-by: Andreas Karis <[email protected]>

Author: andreaskaris

apis/v1alpha1/bpf_application_state_types.go

@@ -50,7 +50,7 @@ type BpfApplicationProgramState struct {
 	// +unionDiscriminator
 	// +required
 	// +kubebuilder:validation:Enum:="XDP";"TC";"TCX";"UProbe";"URetProbe"
-	Type EBPFProgType `json:"type"`
+	Type EBPFProgType `json:"type,omitempty"`
 
 	// xdp contains the attachment data for an XDP program when type is set to XDP.
 	// +unionMember
@@ -81,15 +81,32 @@ type BpfApplicationProgramState struct {
 }
 
 type BpfApplicationStateStatus struct {
-	// UpdateCount tracks the number of times the BpfApplicationState object has
+	// conditions contains the summary state of the BpfApplication for the given
+	// Kubernetes node. If one or more programs failed to load or attach to the
+	// designated attachment point, the condition will report the error. If more
+	// than one error has occurred, condition will contain the first error
+	// encountered.
+	// +patchMergeKey=type
+	// +patchStrategy=merge
+	// +listType=map
+	// +listMapKey=type
+	// +optional
+	// +kubebuilder:validation:MaxItems=1023
+	Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"`
+	// updateCount tracks the number of times the BpfApplicationState object has
 	// been updated. The bpfman agent initializes it to 1 when it creates the
 	// object, and then increments it before each subsequent update. It serves
 	// as a lightweight sequence number to verify that the API server is serving
 	// the most recent version of the object before beginning a new Reconcile
 	// operation.
-	UpdateCount int64 `json:"updateCount"`
-	// node is the name of the Kubernets node for this BpfApplicationState.
-	Node string `json:"node"`
+	// +kubebuilder:validation:Minimum=1
+	// +optional
+	UpdateCount int64 `json:"updateCount,omitempty"`
+	// node is the name of the Kubernetes node for this BpfApplicationState.
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=253
+	// +optional
+	Node string `json:"node,omitempty"`
 	// appLoadStatus reflects the status of loading the eBPF application on the
 	// given node.
 	//
@@ -111,21 +128,15 @@ type BpfApplicationStateStatus struct {
 	//
 	// UnloadError is returned if one or more programs encountered an error when
 	// being unloaded.
-	AppLoadStatus AppLoadStatus `json:"appLoadStatus"`
+	// +optional
+	AppLoadStatus AppLoadStatus `json:"appLoadStatus,omitempty"`
 	// programs is a list of eBPF programs contained in the parent BpfApplication
 	// instance. Each entry in the list contains the derived program attributes as
 	// well as the attach status for each program on the given Kubernetes node.
+	// +kubebuilder:validation:MaxItems=1023
+	// +listType=atomic
+	// +optional
 	Programs []BpfApplicationProgramState `json:"programs,omitempty"`
-	// conditions contains the summary state of the BpfApplication for the given
-	// Kubernetes node. If one or more programs failed to load or attach to the
-	// designated attachment point, the condition will report the error. If more
-	// than one error has occurred, condition will contain the first error
-	// encountered.
-	// +patchMergeKey=type
-	// +patchStrategy=merge
-	// +listType=map
-	// +listMapKey=type
-	Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"`
 }
 
 // +genclient
@@ -141,13 +152,16 @@ type BpfApplicationStateStatus struct {
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[0].reason`
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
 type BpfApplicationState struct {
-	metav1.TypeMeta   `json:",inline"`
+	metav1.TypeMeta `json:",inline"`
+	// metadata is the object's metadata.
+	// +optional
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	// status reflects the status of a BpfApplication instance for the given node.
 	// appLoadStatus and conditions provide an overall status for the given node,
 	// while each item in the programs list provides a per eBPF program status for
 	// the given node.
+	// +optional
 	Status BpfApplicationStateStatus `json:"status,omitempty"`
 }
 

apis/v1alpha1/bpf_application_types.go

@@ -31,12 +31,12 @@ type BpfApplicationProgram struct {
 	// name is a required field and is the name of the function that is the entry
 	// point for the eBPF program. name must not be an empty string, must not
 	// exceed 64 characters in length, must start with alpha characters and must
-	// only contain alphanumeric characters.
+	// only contain alphanumeric characters and underscores.
 	// +required
 	// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=64
-	Name string `json:"name"`
+	Name string `json:"name,omitempty"`
 
 	// type is a required field used to specify the type of the eBPF program.
 	//
@@ -73,7 +73,7 @@ type BpfApplicationProgram struct {
 	// +unionDiscriminator
 	// +required
 	// +kubebuilder:validation:Enum:="XDP";"TC";"TCX";"UProbe";"URetProbe"
-	Type EBPFProgType `json:"type"`
+	Type EBPFProgType `json:"type,omitempty"`
 
 	// xdp is an optional field, but required when the type field is set to XDP.
 	// xdp defines the desired state of the application's XDP programs. XDP program
@@ -163,7 +163,9 @@ type BpfApplicationSpec struct {
 	// programs in the list to be reloaded, which could be temporarily service
 	// effecting. For this reason, modifying the list is currently not allowed.
 	// +required
-	// +kubebuilder:validation:MinItems:=1
+	// +kubebuilder:validation:MinItems=1
+	// +kubebuilder:validation:MaxItems=1023
+	// +listType=atomic
 	Programs []BpfApplicationProgram `json:"programs,omitempty"`
 }
 
@@ -185,11 +187,17 @@ type BpfApplicationSpec struct {
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[0].reason`
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
 type BpfApplication struct {
-	metav1.TypeMeta   `json:",inline"`
+	metav1.TypeMeta `json:",inline"`
+	// metadata is the object's metadata.
+	// +optional
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
-	Spec   BpfApplicationSpec `json:"spec,omitempty"`
-	Status BpfAppStatus       `json:"status,omitempty"`
+	// spec defines the desired state of the BpfApplication.
+	// +required
+	Spec BpfApplicationSpec `json:"spec,omitzero"`
+	// status reflects the observed state of the BpfApplication.
+	// +optional
+	Status BpfAppStatus `json:"status,omitempty"`
 }
 
 // +kubebuilder:object:root=true

apis/v1alpha1/cluster_bpf_application_state_types.go

@@ -71,7 +71,7 @@ type ClBpfApplicationProgramState struct {
 	// +unionDiscriminator
 	// +required
 	// +kubebuilder:validation:Enum:="FEntry";"FExit";"KProbe";"KRetProbe";"TC";"TCX";"TracePoint";"UProbe";"URetProbe";"XDP"
-	Type EBPFProgType `json:"type"`
+	Type EBPFProgType `json:"type,omitempty"`
 
 	// xdp contains the attachment data for an XDP program when type is set to XDP.
 	// +unionMember
@@ -132,15 +132,32 @@ type ClBpfApplicationProgramState struct {
 }
 
 type ClBpfApplicationStateStatus struct {
-	// UpdateCount tracks the number of times the BpfApplicationState object has
+	// conditions contains the summary state of the ClusterBpfApplication for the
+	// given Kubernetes node. If one or more programs failed to load or attach to
+	// the designated attachment point, the condition will report the error. If
+	// more than one error has occurred, condition will contain the first error
+	// encountered.
+	// +patchMergeKey=type
+	// +patchStrategy=merge
+	// +listType=map
+	// +listMapKey=type
+	// +optional
+	// +kubebuilder:validation:MaxItems=1023
+	Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"`
+	// updateCount tracks the number of times the BpfApplicationState object has
 	// been updated. The bpfman agent initializes it to 1 when it creates the
 	// object, and then increments it before each subsequent update. It serves
 	// as a lightweight sequence number to verify that the API server is serving
 	// the most recent version of the object before beginning a new Reconcile
 	// operation.
-	UpdateCount int64 `json:"updateCount"`
+	// +kubebuilder:validation:Minimum=1
+	// +optional
+	UpdateCount int64 `json:"updateCount,omitempty"`
 	// node is the name of the Kubernetes node for this ClusterBpfApplicationState.
-	Node string `json:"node"`
+	// +kubebuilder:validation:MinLength=1
+	// +kubebuilder:validation:MaxLength=253
+	// +optional
+	Node string `json:"node,omitempty"`
 	// appLoadStatus reflects the status of loading the eBPF application on the
 	// given node.
 	//
@@ -160,22 +177,16 @@ type ClBpfApplicationStateStatus struct {
 	//
 	// UnloadError is returned if one or more programs encountered an error when
 	// being unloaded.
-	AppLoadStatus AppLoadStatus `json:"appLoadStatus"`
+	// +optional
+	AppLoadStatus AppLoadStatus `json:"appLoadStatus,omitempty"`
 	// programs is a list of eBPF programs contained in the parent
 	// ClusterBpfApplication instance. Each entry in the list contains the derived
 	// program attributes as well as the attach status for each program on the
 	// given Kubernetes node.
+	// +kubebuilder:validation:MaxItems=1023
+	// +listType=atomic
+	// +optional
 	Programs []ClBpfApplicationProgramState `json:"programs,omitempty"`
-	// conditions contains the summary state of the ClusterBpfApplication for the
-	// given Kubernetes node. If one or more programs failed to load or attach to
-	// the designated attachment point, the condition will report the error. If
-	// more than one error has occurred, condition will contain the first error
-	// encountered.
-	// +patchMergeKey=type
-	// +patchStrategy=merge
-	// +listType=map
-	// +listMapKey=type
-	Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,1,rep,name=conditions"`
 }
 
 // +genclient
@@ -192,13 +203,16 @@ type ClBpfApplicationStateStatus struct {
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[0].reason`
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
 type ClusterBpfApplicationState struct {
-	metav1.TypeMeta   `json:",inline"`
+	metav1.TypeMeta `json:",inline"`
+	// metadata is the object's metadata.
+	// +optional
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	// status reflects the status of a ClusterBpfApplication instance for the given
 	// node. appLoadStatus and conditions provide an overall status for the given
 	// node, while each item in the programs list provides a per eBPF program
 	// status for the given node.
+	// +optional
 	Status ClBpfApplicationStateStatus `json:"status,omitempty"`
 }
 

apis/v1alpha1/cluster_bpf_application_types.go

@@ -77,12 +77,12 @@ type ClBpfApplicationProgram struct {
 	// name is a required field and is the name of the function that is the entry
 	// point for the eBPF program. name must not be an empty string, must not
 	// exceed 64 characters in length, must start with alpha characters and must
-	// only contain alphanumeric characters.
+	// only contain alphanumeric characters and underscores.
 	// +required
 	// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=64
-	Name string `json:"name"`
+	Name string `json:"name,omitempty"`
 
 	// type is a required field used to specify the type of the eBPF program.
 	//
@@ -143,7 +143,7 @@ type ClBpfApplicationProgram struct {
 	// +unionDiscriminator
 	// +required
 	// +kubebuilder:validation:Enum:="XDP";"TC";"TCX";"FEntry";"FExit";"KProbe";"KRetProbe";"UProbe";"URetProbe";"TracePoint"
-	Type EBPFProgType `json:"type"`
+	Type EBPFProgType `json:"type,omitempty"`
 
 	// xdp is an optional field, but required when the type field is set to XDP.
 	// xdp defines the desired state of the application's XDP programs. XDP program
@@ -293,7 +293,9 @@ type ClBpfApplicationSpec struct {
 	// effecting. For this reason, modifying the list is currently not allowed.
 	// +required
 	// +kubebuilder:validation:MinItems:=1
-	Programs []ClBpfApplicationProgram `json:"programs"`
+	// +kubebuilder:validation:MaxItems=1023
+	// +listType=atomic
+	Programs []ClBpfApplicationProgram `json:"programs,omitempty"`
 }
 
 // +genclient
@@ -316,11 +318,17 @@ type ClBpfApplicationSpec struct {
 // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[0].reason`
 // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
 type ClusterBpfApplication struct {
-	metav1.TypeMeta   `json:",inline"`
+	metav1.TypeMeta `json:",inline"`
+	// metadata is the standard object's metadata.
+	// +optional
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
-	Spec   ClBpfApplicationSpec `json:"spec,omitempty"`
-	Status BpfAppStatus         `json:"status,omitempty"`
+	// spec defines the desired state of the BpfApplication.
+	// +required
+	Spec ClBpfApplicationSpec `json:"spec,omitzero"`
+	// status reflects the observed state of the BpfApplication.
+	// +optional
+	Status BpfAppStatus `json:"status,omitempty"`
 }
 
 // +kubebuilder:object:root=true

apis/v1alpha1/cluster_fentry_program_types.go

@@ -30,6 +30,7 @@ type ClFentryProgramInfo struct {
 	// the program, add an entry to links with mode set to Attach. To detach it,
 	// remove the entry from links.
 	// +optional
+	// +listType=atomic
 	// +kubebuilder:validation:MaxItems=1
 	Links []ClFentryAttachInfo `json:"links,omitempty"`
 }
@@ -39,11 +40,11 @@ type ClFentryLoadInfo struct {
 	// function to attach the FEntry program. function must not be an empty string,
 	// must not exceed 64 characters in length, must start with alpha characters
 	// and must only contain alphanumeric characters.
-	// +required
+	// +optional
 	// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=64
-	Function string `json:"function"`
+	Function string `json:"function,omitempty"`
 }
 
 type AttachTypeAttach string
@@ -57,7 +58,7 @@ type ClFentryAttachInfo struct {
 	// attempt to be attached. To detach the FEntry program, remove the link entry.
 	// +required
 	// +kubebuilder:validation:Enum=Attach;
-	Mode AttachTypeAttach `json:"mode"`
+	Mode AttachTypeAttach `json:"mode,omitempty"`
 }
 
 type ClFentryProgramInfoState struct {
@@ -68,6 +69,7 @@ type ClFentryProgramInfoState struct {
 	// successful or not on this node, a linkId, which is the kernel ID for the
 	// link if successfully attached, and other attachment specific data.
 	// +optional
+	// +listType=atomic
 	// +kubebuilder:validation:MaxItems=1
 	Links []ClFentryAttachInfoState `json:"links,omitempty"`
 }

apis/v1alpha1/cluster_fexit_program_types.go

@@ -30,28 +30,30 @@ type ClFexitProgramInfo struct {
 	// the program, add an entry to links with mode set to Attach. To detach it,
 	// remove the entry from links.
 	// +optional
+	// +listType=atomic
 	// +kubebuilder:validation:MaxItems=1
 	Links []ClFexitAttachInfo `json:"links,omitempty"`
 }
 
 type ClFexitLoadInfo struct {
 	// function is a required field and specifies the name of the Linux kernel
 	// function to attach the FExit program. function must not be an empty string,
-	// must not exceed 64 characters in length, must start with alpha characters
-	// and must only contain alphanumeric characters.
-	// +required
+	// must be between 1 and 64 characters in length, must start with alpha
+	// characters and must only contain alphanumeric characters and underscores.
+	// The pattern ^[a-zA-Z][a-zA-Z0-9_]+. is enforced.
+	// +optional
 	// +kubebuilder:validation:Pattern="^[a-zA-Z][a-zA-Z0-9_]+."
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=64
-	Function string `json:"function"`
+	Function string `json:"function,omitempty"`
 }
 
 type ClFexitAttachInfo struct {
 	// mode is a required field. When set to Attach, the FExit program will
 	// attempt to be attached. To detach the FExit program, remove the link entry.
 	// +required
 	// +kubebuilder:validation:Enum=Attach;
-	Mode AttachTypeAttach `json:"mode"`
+	Mode AttachTypeAttach `json:"mode,omitempty"`
 }
 
 type ClFexitProgramInfoState struct {
@@ -62,6 +64,7 @@ type ClFexitProgramInfoState struct {
 	// successful or not, a linkId, which is the kernel ID for the link if
 	// successfully attached, and other attachment specific data.
 	// +optional
+	// +listType=atomic
 	// +kubebuilder:validation:MaxItems=1
 	Links []ClFexitAttachInfoState `json:"links,omitempty"`
 }