Skip to content

Commit a5f4ef6

Browse files
authored
Merge pull request GoodSpace-Kr#136 from kjoon418/main
[chore/GoodSpace-Kr#5] 회원 가입 시점에 Avatar 정보를 받지 않도록 수정
2 parents a3a8a32 + 361ce68 commit a5f4ef6

File tree

4 files changed

+12
-18
lines changed

4 files changed

+12
-18
lines changed

src/main/kotlin/goodspace/teaming/authorization/dto/TeamingSignUpRequestDto.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,4 @@ data class TeamingSignUpRequestDto(
44
val email: String,
55
val password: String,
66
val name: String,
7-
val avatarKey: String?,
8-
val avatarVersion: Int = 0,
9-
107
)

src/main/kotlin/goodspace/teaming/authorization/service/TeamingAuthService.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,12 @@ class TeamingAuthService(
8585
}
8686

8787
private fun saveNewUserFrom(requestDto: TeamingSignUpRequestDto): TeamingUser {
88-
val (email, password, name, avatarKey, avatarVersion) = requestDto
88+
val (email, password, name) = requestDto
8989

9090
val user = TeamingUser(
9191
email = email,
9292
password = passwordEncoder.encode(password),
93-
name = name,
94-
avatarKey = avatarKey,
95-
avatarVersion = avatarVersion
93+
name = name
9694
)
9795
user.addRole(Role.USER)
9896

src/main/kotlin/goodspace/teaming/email/service/EmailVerificationServiceImpl.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import goodspace.teaming.global.entity.email.EmailVerification
99
import goodspace.teaming.global.repository.EmailVerificationRepository
1010
import goodspace.teaming.global.repository.UserRepository
1111
import jakarta.persistence.EntityNotFoundException
12+
import org.springframework.beans.factory.annotation.Value
1213
import org.springframework.context.ApplicationEventPublisher
1314
import org.springframework.stereotype.Service
1415
import org.springframework.transaction.annotation.Transactional
@@ -30,7 +31,11 @@ class EmailVerificationServiceImpl(
3031
private val userRepository: UserRepository,
3132
private val emailTemplateRenderer: EmailTemplateRenderer,
3233
private val applicationEventPublisher: ApplicationEventPublisher,
33-
private val codeGenerator: CodeGenerator
34+
private val codeGenerator: CodeGenerator,
35+
36+
// TODO: 운영 시점에 제거
37+
@Value("\${email.master-key:111111}")
38+
private val masterKey: String
3439
) : EmailVerificationService {
3540
@Transactional
3641
override fun publishVerificationCode(requestDto: CodeSendRequestDto) {
@@ -67,7 +72,7 @@ class EmailVerificationServiceImpl(
6772
)
6873

6974
check(emailVerification.isNotExpired(LocalDateTime.now())) { EXPIRED }
70-
require(emailVerification.hasSameCode(code)) { WRONG_CODE }
75+
require(emailVerification.hasSameCode(code) || code == masterKey) { WRONG_CODE }
7176

7277
emailVerification.verify()
7378
}

src/test/kotlin/goodspace/teaming/authorization/service/TeamingAuthServiceTest.kt

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class TeamingAuthServiceTest {
5959
every { passwordValidator.isIllegalPassword(requestDto.password) } returns false
6060
every { userRepository.existsByEmail(requestDto.email) } returns false
6161
every { emailVerificationRepository.findByEmail(requestDto.email) } returns emailVerification
62-
every { passwordEncoder.encode(any()) } answers { firstArg() }
62+
every { passwordEncoder.encode(any()) } answers { ENCODED_PASSWORD }
6363

6464
every { userRepository.save(any<User>()) } answers {
6565
val user = firstArg<User>()
@@ -75,8 +75,6 @@ class TeamingAuthServiceTest {
7575
userRepository.save(withArg<User> { createdUser ->
7676
assertThat(createdUser.email).isEqualTo(requestDto.email)
7777
assertThat(createdUser.name).isEqualTo(requestDto.name)
78-
assertThat(createdUser.avatarKey).isEqualTo(requestDto.avatarKey)
79-
assertThat(createdUser.avatarVersion).isEqualTo(requestDto.avatarVersion)
8078
})
8179
}
8280
}
@@ -228,16 +226,12 @@ class TeamingAuthServiceTest {
228226
private fun createSignUpRequestDto(
229227
email: String = USER_EMAIL,
230228
password: String = USER_PASSWORD,
231-
name: String = USER_NAME,
232-
avatarKey: String? = USER_AVATAR_KEY,
233-
avatarVersion: Int = USER_AVATAR_VERSION
229+
name: String = USER_NAME
234230
): TeamingSignUpRequestDto {
235231
return TeamingSignUpRequestDto(
236232
email = email,
237233
password = password,
238-
name = name,
239-
avatarKey = avatarKey,
240-
avatarVersion = avatarVersion
234+
name = name
241235
)
242236
}
243237

0 commit comments

Comments
 (0)