extract: misc. fixes for restoring linux fs flags #9089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #9089 +/- ##
==========================================
Coverage 80.60% 80.60%
==========================================
Files 38 38
Lines 11250 11250
Branches 1767 1767
==========================================
Hits 9068 9068
Misses 1611 1611
Partials 571 571 ☔ View full report in Codecov by Sentry. |
…ckup#9039 Linux platform only.
ThomasWaldmann
force-pushed
the
fix-set_flags-1.4
branch
from
469fd5a to
9214197
Compare
ThomasWaldmann
commented
Oct 16, 2025
Thanks to Earnestly for the feedback on IRC.
ThomasWaldmann
force-pushed
the
fix-set_flags-1.4
branch
from
2a773ec to
9c600a9
Compare
This flag needs to be set BEFORE writing to the file. But "borg extract" sets the flags last (to support IMMUTABLE), thus the compression flag would not work as expected.
ThomasWaldmann
changed the title
|
@ThomasWaldmann This approach looks good to me, @jirislaby what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.