remove weak tests

Author: theodore-s-beers

checks/cli.go

@@ -58,10 +58,6 @@ func (b *boundedBuffer) String() string {
 	return b.buffer.String()
 }
 
-func (b *boundedBuffer) Truncated() bool {
-	return b.truncated
-}
-
 func runCLICommand(command api.CLIStepCLICommand, variables map[string]string) (result api.CLICommandResult) {
 	return runCLICommandWithLimits(command, variables, cliCommandTimeout, maxCLIOutputBytesPerStream)
 }

checks/cli_test.go

@@ -74,30 +74,6 @@ func TestRunCLICommandCapsOutput(t *testing.T) {
 	}
 }
 
-func TestBoundedBufferDiscardsExcessBytes(t *testing.T) {
-	truncations := 0
-	buffer := newBoundedBuffer(5, func() {
-		truncations++
-	})
-	written, err := buffer.Write([]byte("abcdefgh"))
-	if err != nil {
-		t.Fatalf("Write() error = %v", err)
-	}
-	if written != 8 {
-		t.Fatalf("Write() = %d, want 8", written)
-	}
-	if got := buffer.String(); got != "abcde" {
-		t.Fatalf("buffer = %q, want abcde", got)
-	}
-	if !buffer.Truncated() {
-		t.Fatal("buffer did not record truncation")
-	}
-	_, _ = buffer.Write([]byte("more"))
-	if truncations != 1 {
-		t.Fatalf("truncation callback invoked %d times, want once", truncations)
-	}
-}
-
 func TestRunCLICommandCapturesStdoutVariables(t *testing.T) {
 	variables := map[string]string{}
 	result := runCLICommand(api.CLIStepCLICommand{
@@ -178,21 +154,6 @@ func TestRunCLICommandInterpolatesCapturedStdoutVariables(t *testing.T) {
 	}
 }
 
-func TestParseStdoutVariablesRequiresOneCaptureGroup(t *testing.T) {
-	variables := map[string]string{}
-	err := parseStdoutVariables("token=abc123", []api.CLICommandStdoutVariable{{
-		Name:  "token",
-		Regex: `token=([a-z]+)([0-9]+)`,
-	}}, variables)
-
-	if err == nil {
-		t.Fatal("expected parse error")
-	}
-	if err.Error() != "invalid stdout variable configuration" {
-		t.Fatalf("error = %q, want invalid stdout variable configuration", err.Error())
-	}
-}
-
 func TestParseStdoutVariablesUsesGenericConfigurationError(t *testing.T) {
 	tests := []struct {
 		name   string

checks/http_test.go

@@ -7,7 +7,6 @@ import (
 	"net/http/httptest"
 	"strings"
 	"testing"
-	"time"
 
 	api "github.com/bootdotdev/bootdev/client"
 )
@@ -240,39 +239,6 @@ func TestRunHTTPRequestCapsResponseBodyRead(t *testing.T) {
 	}
 }
 
-func TestRunHTTPRequestHonorsClientTimeout(t *testing.T) {
-	const timeout = 20 * time.Millisecond
-	client := &http.Client{
-		Timeout: timeout,
-		Transport: httpRoundTripFunc(func(r *http.Request) (*http.Response, error) {
-			<-r.Context().Done()
-			return nil, r.Context().Err()
-		}),
-	}
-	requestStep := api.CLIStepHTTPRequest{
-		Request: api.HTTPRequest{
-			Method:  http.MethodGet,
-			FullURL: "http://example.test",
-		},
-	}
-
-	start := time.Now()
-	result := runHTTPRequest(client, "", map[string]string{}, requestStep)
-	elapsed := time.Since(start)
-	if result.Err == "" {
-		t.Fatal("runHTTPRequest() unexpectedly succeeded")
-	}
-	if elapsed > time.Second {
-		t.Fatalf("runHTTPRequest() took %v, want a prompt timeout", elapsed)
-	}
-}
-
-func TestLessonHTTPClientUsesConfiguredTimeout(t *testing.T) {
-	if got := newLessonHTTPClient().Timeout; got != lessonHTTPRequestTimeout {
-		t.Fatalf("lesson HTTP client timeout = %v, want %v", got, lessonHTTPRequestTimeout)
-	}
-}
-
 func TestRunHTTPRequestCapturesResponseHeaderVariableAndDoesNotFollowRedirect(t *testing.T) {
 	followRedirects := false
 

checks/jq_test.go

@@ -97,34 +97,6 @@ func TestParseJqInputRejectsMultipleJSONValuesInJSONMode(t *testing.T) {
 	}
 }
 
-func TestFormatJqResults(t *testing.T) {
-	got := formatJqResults([]any{"hello", float64(42), true, nil, map[string]any{"id": float64(1)}})
-	want := []string{`"hello"`, `42`, `true`, `null`, `{"id":1}`}
-	if !reflect.DeepEqual(got, want) {
-		t.Fatalf("formatJqResults() = %#v, want %#v", got, want)
-	}
-}
-
-func TestFormatJqExpectedValueInterpolatesOnlyStrings(t *testing.T) {
-	variables := map[string]string{"name": "Allan"}
-
-	gotString := formatJqExpectedValue(api.JqExpectedResult{
-		Type:  api.JqTypeString,
-		Value: "hello ${name}",
-	}, variables)
-	if gotString != `"hello Allan"` {
-		t.Fatalf("expected interpolated string value, got %q", gotString)
-	}
-
-	gotInt := formatJqExpectedValue(api.JqExpectedResult{
-		Type:  api.JqTypeInt,
-		Value: "${name}",
-	}, variables)
-	if gotInt != `"${name}"` {
-		t.Fatalf("expected non-string jq type to avoid interpolation, got %q", gotInt)
-	}
-}
-
 func TestValFromJqPath(t *testing.T) {
 	tests := []struct {
 		name    string

client/auth_test.go

@@ -79,9 +79,3 @@ func TestLogoutReturnsConfigWriteError(t *testing.T) {
 		t.Fatalf("logout() error = %q, want config write error", err)
 	}
 }
-
-func TestLogoutCommandDoesNotRequireAuthentication(t *testing.T) {
-	if logoutCmd.PreRun != nil {
-		t.Fatal("logout command unexpectedly requires authentication")
-	}
-}

cmd/logout_test.go

@@ -10,37 +10,6 @@ import (
 	"time"
 )
 
-func TestGetLatestVersionRespectsGoProxyOff(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		t.Skip("test uses a POSIX executable script")
-	}
-
-	dir := t.TempDir()
-	fakeGo := filepath.Join(dir, "go")
-	script := `#!/bin/sh
-if [ "$GOPROXY" != "off" ]; then
-	echo "unexpected GOPROXY: $GOPROXY" >&2
-	exit 1
-fi
-printf '{"Version":"v1.2.3"}'
-`
-	if err := os.WriteFile(fakeGo, []byte(script), 0o755); err != nil {
-		t.Fatalf("create fake go command: %v", err)
-	}
-	t.Setenv("PATH", dir)
-	t.Setenv("GOPROXY", "off")
-	t.Setenv("GOPRIVATE", "")
-	t.Setenv("GONOPROXY", "none")
-
-	latest, err := getLatestVersionWithTimeout(time.Second)
-	if err != nil {
-		t.Fatalf("get latest version: %v", err)
-	}
-	if latest != "v1.2.3" {
-		t.Fatalf("latest version = %q, want v1.2.3", latest)
-	}
-}
-
 func TestGetLatestVersionHasOverallTimeout(t *testing.T) {
 	if runtime.GOOS == "windows" {
 		t.Skip("test uses a POSIX executable script")