-
Notifications
You must be signed in to change notification settings - Fork 11
부스트캠프 6기 iOS 코드 리뷰어 지원 🍎 #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seoulboy
wants to merge
418
commits into
boostcamp-2020:review
Choose a base branch
from
seoulboy:review
base: review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84,001
−1
Open
Changes from all commits
Commits
Show all changes
418 commits
Select commit
Hold shift + click to select a range
903713f
(#88) chore: 불필요한 self는 생략한다
seoulboy bec1b89
(#101) feat: activityVC/VM 연결 및 Activity Filter 자료구조 설정
SHIVVVPP 8afc6d9
(#101) feat: Activity CreateAt 옵셔널 해제 및 수정
SHIVVVPP 2b1aa41
(#101) style: Lint 경고에 따라 컨벤션 처리
SHIVVVPP 309a5f4
(#101) feat: ActivityFilter 구현 및 연결
SHIVVVPP 600686e
(#101) feat: filterView 시작 시 선택된 날짜가 표시되는 기능
SHIVVVPP 4696552
(#101) style: 코드 컨벤션 정리
SHIVVVPP 6c2d79d
(#101) style: tabbar 확인용 배경색 지정 해제
SHIVVVPP a427414
(#101) feat: activityCell 값 입력 구현
SHIVVVPP 0c16c5a
(#101) fix: CI 실패 -> 테스트 타깃 지정
SHIVVVPP ffc3a43
(#97) feat: running split scene 구현
whrlgus aef8310
Merge pull request #103 from boostcamp-2020/feature/101
SHIVVVPP 735a832
Merge branch 'master' into feature/97
whrlgus 963169d
Merge pull request #104 from boostcamp-2020/feature/97
whrlgus d580c82
Merge pull request #106 from boostcamp-2020/feature/91
seoulboy acd804c
(#86) feat: activityScene TableView와 CollectionView로 분리
SHIVVVPP 5353cab
Merge branch 'master' into feature/88
seoulboy 2845a58
Merge pull request #107 from boostcamp-2020/feature/88
seoulboy bef04b5
(#105) fix: location 배열이 비어있을 때 발생하는 에러 수정
whrlgus 0f866a8
(#90) feat: ProfileSceneFactory 에 ProfileView에 필요한 뷰컨트롤러와 뷰모델 생성 로직 추가
seoulboy 17ccfaa
(#90) feat: EditProfile 뷰 추가 로직을 담은 EditProfileSceneFactory 추가
seoulboy 6052c9d
(#90) feat: ProfileViewModel 생성
seoulboy 6f86a91
(#90) feat: ProfileScene의 뷰 구현
seoulboy 8ccd3ff
(#90) feat: ProfileCoordinator에 화면전환 로직 추가 (ProfileScene <--> EditPro…
seoulboy cf8667a
(#90) feat: Profile 구조체 추가
seoulboy ed809de
(#90) feat: EditProfileViewModel 추가
seoulboy 1c767f5
(#90) EditProfileScene 뷰 Navigation Item 구현
seoulboy 5421bea
(#86) feat: Activity TableCell -> CollectionView로 변경
SHIVVVPP 1ff2d3f
Merge branch 'master' into feature/86
SHIVVVPP 7513967
(#112) feat: dateFilterSheet 배경 블러 색 수정
SHIVVVPP 5b9c0e2
(#114) feat: activityListScene coordinator 연결
SHIVVVPP acf0097
(#114) feat: 모든 활동 리스트 화면 구현
SHIVVVPP 6fdbd83
(#114) feat: ActivityList Cell 선택 이벤트 연결
SHIVVVPP 30b588e
(#90) feat: EditProfileScene 뷰 구현
seoulboy 5ab149c
(#105) feat: 스크롤할 때 버튼 크기 조절
whrlgus 6943a36
(#90) refactor: Profile 구조체 프로퍼티 수정: name -> lastName, firstName
seoulboy 038b7b1
(#90) feat: 텍스트필드 및 텍스트뷰 뷰모델 연결
seoulboy 319aa92
(#90) feat: info.plist에 NSPhotoLibraryUsageDescription 추가
seoulboy cf9d3e8
(#90) feat: EditProfileScene에서 저장시 화면을 닫는다
seoulboy 2ef6639
(#90) style: return 생략
seoulboy 6cd1aa4
(#105) feat: 스크롤할 때 pagecontrol alpha 처리
whrlgus 2280e1c
(#114) style: 필요없는 return 키워드 제거
SHIVVVPP 4d243ef
(#114) refactor: ActivityListVM makeListDataSource 처리
SHIVVVPP 1f3fa57
Merge pull request #115 from boostcamp-2020/feature/114
seoulboy 7de7f1c
(#117) feat: activity List 출력시 날짜 출력형식 변경
SHIVVVPP fa45d77
(#117) style: 불필요 주석 제거
SHIVVVPP 227a597
(#119) feat: filter와 total view에서 이번 주, 저번 주로 표시
SHIVVVPP c8b5c3f
(#119) style: 불필요 주석 삭제
SHIVVVPP 2fd4203
(#119) fix: filter에서 rangeGroup 생성 시 .all 타입에 range 생성 오류 수정
SHIVVVPP 3565e7a
(#117) feat: week 선택시 같은 년도가 아니면 년도 표시
SHIVVVPP 72b0dec
(#105) feat: running time back button에 바인딩
whrlgus 3f5659e
(#121) fix: coreData UUID 오류 수정
SHIVVVPP 146c458
(#121) feat: MKCoordinateRegion+ Coordinator2d 배열로 Region 생성
SHIVVVPP 5806bef
(#121) feat: Running 종료시 snapShot 저장 및 불러오기
SHIVVVPP 81faa36
fix: map location 빈 경우 예외 처리
whrlgus 8d65022
Merge branch 'master' into feature/121
SHIVVVPP c6201fb
fix: map location 빈 경우 예외 처리
whrlgus 38b553a
Merge branch 'master' into feature/121
SHIVVVPP 3eba4bf
hotfix: runningMapViewModel viewWillAppear시 배열 범위 검증
SHIVVVPP fc3e781
hotfix: motion 센서 민감도 수정
seoulboy 9f9f7a7
Merge branch 'master' into feature/121
SHIVVVPP 88bd6a4
(#90) feat: Data 및 URL Extension 추가
seoulboy 43bacba
(#90) feat: Depedency factory에 defaults 추가
seoulboy 2e2d205
(#90) feat: ProfileScene 구현
seoulboy fd5f760
Merge branch 'master' into feature/121
SHIVVVPP 8021d43
(#121) feat: CoreData 저장이 완료된 후 완료 시그널을 보내는 기능
SHIVVVPP 0bd46d3
(#121) fix: 러닝 중단 시 2번 저장되던 문제 해결
SHIVVVPP 5304504
(#121) feat: RunningDataProvider에 MapSnapShotService 주입
SHIVVVPP cdfa50b
(#121) style: 불필요 코드 제거 (setNeedLayout/LayoutIfNeeded)
SHIVVVPP d77f4db
(#124) feat: TabBar Icon 추가
SHIVVVPP 4bdc6bd
(#126) feat: runningData 시간 HH:MM or MM:ss로 표시하도록 변경
SHIVVVPP e1c50f7
(#90) feat: UserDefaults layer - DefaultsProvider 추가
seoulboy 991ef85
(#90) refactor: DependencyFactory에서 UserDefaults 를 사용하던 부분을 DefaultsP…
seoulboy cddd934
(#90) refactor: EditProfileVM과 ProfileVM에 DefaultsProvidable 적용
seoulboy e4defbb
(#90) refactor: ProfileCoordinator에서 profileVM에 대한 약한 참조 처리
seoulboy c674c8a
(#90) style: 한줄이 너무 길어지지 않도록 개행을 추가
seoulboy b418fce
(#90) refactor: EditProfileVC과 ProfileVC의 함수에 private 레벨의 접근자 추가
seoulboy b7533ca
(#90) refactor: 프로젝트 파일 변경사항 추가
seoulboy 68606db
Merge pull request #118 from boostcamp-2020/feature/117
SHIVVVPP c5db6c8
Merge pull request #120 from boostcamp-2020/feature/119
SHIVVVPP fdb285a
Merge branch 'master' into feature/90
seoulboy 8eab1cc
Merge pull request #122 from boostcamp-2020/feature/90
seoulboy 3f28b28
Merge branch 'master' into feature/121
SHIVVVPP 261c969
fix: merge후 컴파일러 에러 수정
SHIVVVPP 7713f5f
Merge pull request #123 from boostcamp-2020/feature/121
SHIVVVPP b53216e
Merge pull request #125 from boostcamp-2020/feature/124
SHIVVVPP a7a61fd
Merge pull request #127 from boostcamp-2020/feature/126
SHIVVVPP 39782c2
(#105) feat: vm 바인딩 오류 해결중
whrlgus c39b4df
(#122) fix: 아무 로케이션정보가 없을 때 스냅샷을 찍지 않음
SHIVVVPP fc9a37f
Update README.md
whrlgus badd07a
(#105) feat: 바인딩 오류 해결, 그러나 bug 존재
whrlgus 3ce2b30
(#105) feat: RunningPageVC, VM 코드 정리
whrlgus a3d0dea
(#128) feat: ActivityDetailScene 기본 요소 생성 및 연결
SHIVVVPP ae56dec
(#128) style: swiftFormat
SHIVVVPP 5893c70
(#129) feat: edit profile scene scrollview으로 교체
seoulboy e6459c9
(#129) chore: 코드 스타일 정리 및 주석 추가
seoulboy a342b87
(#128) feat: detailScene 기본 화면 구성
SHIVVVPP e9f7602
(#128) feat: detail 화면 구성 완료
SHIVVVPP 3dd6d64
Update README.md
seoulboy afd023f
Update README.md
seoulboy 8668c15
(#105) feat: backButton에 진행시간 표시, 드래깅 중 안됨
whrlgus e8f1634
(#105) feat: 드래깅중 backButton에 진행시간 표기
whrlgus 715770e
Merge branch 'master' into feature/105
whrlgus 9148d39
(#128) feat: detailScene simpleSplitTableView dataSource
SHIVVVPP 119f940
(#105) feat: TimeInterval.fullFormattedString 로 적용
whrlgus 459548d
(#128) feat: ActivityDetailConfig 구조체 생성
SHIVVVPP b638aab
(#128) feat: detailVC detailVM 데이터 연결
SHIVVVPP a802320
(#129) feat: 변경사항이 없을 시 저장 버튼 비활성화
seoulboy a7d0403
(#128) feat: detail map 상에 경로 표시(임시)
SHIVVVPP b8fcd96
(#128) feat: Detail VC Input VM과 연결
SHIVVVPP a575368
(#128) feat: AutoLayout 정리 및 Combine Closure weak 처리
SHIVVVPP 43e43a6
(#129) refactor: 불필요한 스크롤뷰 제약사항 제거
seoulboy e777b8e
(#137) feat: Detail Running value 애니메이션 추가
SHIVVVPP b50ae2f
(#137) feat: ViewModel Input ViewDidAppear 추가
SHIVVVPP dca6919
(#137) feat: DetailView 등장 애니메이션
SHIVVVPP e93eb67
(#105) feat: 주석 해제 및 가로모드 방지
whrlgus a685a62
(#128) feat: desc -> description
SHIVVVPP 6bf0864
Merge pull request #133 from boostcamp-2020/feature/129
seoulboy bc259a5
Merge pull request #132 from boostcamp-2020/feature/105
seoulboy 32ac6c4
Merge pull request #135 from boostcamp-2020/feature/128
seoulboy 0c07650
(#128) feat: simpleSplitsCell 간격 수정
SHIVVVPP 2cd1897
(#128) style: 컨벤셔닝
SHIVVVPP 7224136
(#138) 불필요 구문삭제
SHIVVVPP 48209c4
(#140) feat: RunningInfo 화면 Load시 모든 뷰 alpha = 0 처리
SHIVVVPP 00bffe3
(#140) feat: longPressCircleButton 추가
SHIVVVPP f21047d
(#140) feat: 버튼이벤트 VM과 연결
SHIVVVPP 42cc30d
(#130) feat: statubar 배경 설정
whrlgus 1683efa
(#140) feat: 러닝 재개시 버튼이 안보이던 문제 수정
SHIVVVPP 158ad2f
Merge pull request #139 from boostcamp-2020/feature/138
seoulboy 5b65100
(#134) feat: RouteDetailView 화면 전환 및 지도 Region 설정
seoulboy 08820bb
Merge pull request #141 from boostcamp-2020/feature/140
SHIVVVPP 6d89bcb
style: configureLayout lint function_body_length 예외
SHIVVVPP 38b984c
(#134) feat: 일정 구간마다 custom annotation 추가
seoulboy 12db0cf
(#142) fix: simpleSplits 수치 계산이 그래프에 반영 안되던 문제
SHIVVVPP e059b0f
(#142) fix: SimpleSplit에서 paceRatio 계산시 0으로 나뉘던 예외 처리
SHIVVVPP 072b38b
(#130) feat: 테이블 뷰로 수정하기 전
whrlgus d29687f
Merge pull request #143 from boostcamp-2020/feature/142
seoulboy f0ec478
(#146) refactor: coordinator + PassthroughSubject<Result>
SHIVVVPP a6eda25
(#146) feat: Coordinator 생성 & 해제 확인
SHIVVVPP 60bf64d
(#146) feat: Login 페이지 삭제
SHIVVVPP 6a21583
(#146) fix: RunningInfoVC가 해제되지 않아 Leak이 발생하는 문제 해결
SHIVVVPP cf557d0
(#146) feat: ActivityListCoordinator -> DetailCoordinator 연결
SHIVVVPP e225b57
Merge branch 'master' into feature/146
SHIVVVPP ee13b35
(#146) test: 수정된 GoalInfo type, value 명칭 변경
SHIVVVPP 1a61472
(#147) feat: 러닝 중 기본적인 음성 피드백 지원 - 시작, 재시작, 일시정지
seoulboy 7442998
(#150) feat: 러닝 여부에 따른 종료시 화면전환 분기처리
SHIVVVPP a4a6148
(#150) style: RunningCoordinationResult .detail -> .activityDetail
SHIVVVPP a31d3c6
(#130) feat: 뷰모델 연결
whrlgus 245f8f1
(#130) feat: 상단 뷰 시간 표시
whrlgus da7352b
Merge branch 'master' into feature/130
whrlgus ee2a583
(#147) refactor: Running Data Provider 바인딩 통한 음성피드백 구현
seoulboy 3edaf94
Merge pull request #148 from boostcamp-2020/feature/146
SHIVVVPP 4d1e7a2
(#147) fix: test target에 RunningEvent 추가
seoulboy fbe8ebc
Merge pull request #149 from boostcamp-2020/feature/147
seoulboy 5ba2354
Merge pull request #151 from boostcamp-2020/feature/150
SHIVVVPP 7650c88
Merge branch 'master' into feature/130
whrlgus d199d03
Merge pull request #152 from boostcamp-2020/feature/130
whrlgus 0ee4acd
(#153) hotfix: 러닝 종료시 앱이 중단되는 버그 수정
seoulboy 923d373
(#154) feat: CoreML Activity Classifier를 이용한 모션 타입 감지
seoulboy 01ea5a1
(#154) fix: test target에 추가
seoulboy 469938e
Merge pull request #155 from boostcamp-2020/feature/154
SHIVVVPP bc5628f
(#156) feat: pace별 gradient layer
SHIVVVPP fd819b5
(#156) feat: gradient 생성 실패시 Gstate restore
SHIVVVPP 0436718
Merge pull request #160 from boostcamp-2020/feature/156
SHIVVVPP a070a24
Merge Activity Detail Mapview tasks - annotations and polyline gradient
seoulboy 1ccd905
(#134) fix: RouteDetail에서 경로가 보이지 않던 문제 수정
seoulboy 635290e
Merge pull request #162 from boostcamp-2020/feature/134
seoulboy 7d2afed
(#164) gradient 계산 RGB -> Hue Saturation Brightness로 변경
SHIVVVPP 35e2b9e
(#164) style: 사용하지 않는 변수 삭제
SHIVVVPP 34d4090
(#157) 구간 상세 화면 뷰 간격조정 및 폰트 크기 수정
whrlgus 9e2d46a
(#158) 러닝 준비 화면 현재 위치 보여주게 수정
whrlgus eb93060
(#163) feat: 프로필 버튼 사이즈 변경 및 버튼 이미지 적용
seoulboy 422872e
(#163) feat: 이미지 편집 후에 프로필 버튼에 업데이트 적용
seoulboy ded0275
(#163) fix: prepareRun에서 로드시 깜빡임 수정
seoulboy aa0c2fc
(#131) fix: 버튼 클릭후 드래깅으로 되돌아갈 때 발생하는 오류 수정
whrlgus a8b90e8
(#131) feat: 방향에 따른 화살표 표시
whrlgus fbbbeb8
(#131) feat: running map 화면 exit 버튼 추가 및 연결, 애니매이션 구현
whrlgus ae9f003
Merge branch 'master' into feature/131
whrlgus e2da31b
Merge pull request #165 from boostcamp-2020/feature/164
SHIVVVPP 17b6601
Merge branch 'master' into feature/131
whrlgus 220e430
(#163) feat: 프로필 버튼 화면전환 구현
seoulboy ddbc02d
Merge pull request #166 from boostcamp-2020/feature/131
whrlgus f6eb311
Merge pull request #167 from boostcamp-2020/feature/163
seoulboy 64b76eb
(#169) style: App Icon 추가
seoulboy 3772f0c
(#171) style: TabBarIcon 이미지 및 배경색 변경
seoulboy 96da7d8
(#172) style: 시작 버튼 사이즈 및 제약 사항 수정
seoulboy f35a3a7
(#173) 다크모드 지원 컬러 설정
whrlgus f39060b
(#174) style: goal type setup view 두께 조절 및 뷰가 최대한 유사하도록 조정
seoulboy d4f2f3a
(#168) refactor: RunningDataProvider 역할 분리 리펙터링
SHIVVVPP 18812fe
fix: 더미 데이터 제거 및 데이터 출력 형식 보완
whrlgus 2e53dd6
(#168) refactor: motion provider/ pedometer 분리
SHIVVVPP 522dbf6
(#168) feat: paused run 오버레이
SHIVVVPP 0916666
Merge pull request #170 from boostcamp-2020/feature/169
SHIVVVPP cc1ad62
Merge pull request #176 from boostcamp-2020/feature/172
SHIVVVPP 0dba418
Merge pull request #175 from boostcamp-2020/feature/171
SHIVVVPP 771b513
Merge pull request #177 from boostcamp-2020/feature/174
SHIVVVPP 9e7de5a
(#168) fix: test 타깃 지정
SHIVVVPP 7d9ca17
Merge pull request #178 from boostcamp-2020/feature/168
SHIVVVPP 2a622d4
배포 준비
SHIVVVPP d937dd1
fix: runningBoard clear시 numLocationCeived 초기화
SHIVVVPP eca2bf2
(#179) fix: RunningBoard Clear, Location auto pause to false
SHIVVVPP bcffd7f
(#179) 맵 스냅샷 draw 보완
SHIVVVPP dd94a8b
Update README.md
seoulboy 38006a3
Update README.md
seoulboy 4b1e196
(#179) fix: activity 화면 cell 로드 애니메이션 수정
SHIVVVPP d8d9471
(#179) style: 불필요 주석 삭제
SHIVVVPP c160847
Merge pull request #182 from boostcamp-2020/hotfix/179
SHIVVVPP 9fbe4ea
fix: runningSlice Index 참조 오류
SHIVVVPP a920cc2
fix: motionProvider debounce 3
SHIVVVPP ac4fc3e
style: 코드 컨벤션 적용
SHIVVVPP c659247
refactor: 러닝 슬라이스 저장방식과 km 어노테이션 추가방식 수정
SHIVVVPP e20acce
refactor: pace별 slice
SHIVVVPP 298ba34
chore: 다크모드 컬러 적용
whrlgus d53851b
fix: split detail km 표시 수정
SHIVVVPP 8b2c9ba
fix: coremotion event combine to throttle
SHIVVVPP 0f0d05e
Merge branch 'master' into feature/splitDetailErr
SHIVVVPP b07125a
refactor: provider -> Service -> ViewModel 관계로 이름 통일
SHIVVVPP 5e0fd48
(#189) style: 다크모드 컬러셋 추가 및 적용
seoulboy be70508
Merge pull request #190 from boostcamp-2020/feature/189
seoulboy 1e79c49
style: PassthroughSubject CurrentValueSubject 네이밍 규칙 적용
SHIVVVPP 2c0ddf6
Merge branch 'master' into feature/splitDetailErr
SHIVVVPP be67a48
style: viewModel Input Output 구조 일치화
SHIVVVPP dc2ce7c
refactor: prepareRun goalTypeVM, goalValueSetupVM factory에서 생성
SHIVVVPP fe685ab
chore: extension 파일 구조 분리
SHIVVVPP f49e7ea
Update README.md
SHIVVVPP 1fe78a7
feat: Map 경로 자연스러운 그라데이션 처리
SHIVVVPP b362957
refactor: Activity Calssifier 모델 보안
SHIVVVPP 2ee8a8f
chore: ActivityClassifier DataSet
SHIVVVPP 2cf3ee9
fix: running 재개 후 resume 애니메이션이 반복되는 현상 수정
SHIVVVPP 6a33a97
Update README.md
seoulboy 829ee3c
Update README.md
seoulboy ba1f853
Update README.md
seoulboy 5620154
Update README.md
seoulboy a35b607
Update README.md
seoulboy 4a24d16
(#191) fix: 다크모드 및 라이트모드 toggle시 annotation이 바뀌는 버그 수정
seoulboy 69d6baa
test: Provider, Service Mock 객체 만들기
SHIVVVPP 30e1be9
Merge pull request #192 from boostcamp-2020/feature/191
SHIVVVPP 580f8c2
Merge branch 'master' into fix/136/161/179
SHIVVVPP 73727cc
Merge pull request #193 from boostcamp-2020/fix/136/161/179
SHIVVVPP 483cdfe
Update README.md
whrlgus 3aaa1e5
fix: Calorie 누적 오류 Int -> Double
SHIVVVPP da49bde
Update README.md
whrlgus 4cb7e94
fix: CI CD Dependency 수정
SHIVVVPP f4d18e3
fix: pausedWorkout 사운드 문제
SHIVVVPP 3a55c70
Merge pull request #195 from boostcamp-2020/hotfix/194
SHIVVVPP 35bd30b
fix: test target 지정 및 변수명 수정사항 적용
SHIVVVPP a04cb3f
(#198) feat: split detail 데이터 바인딩
whrlgus 975d649
Update README.md
seoulboy be40816
Merge pull request #197 from boostcamp-2020/hotfix/196
SHIVVVPP 61a9e89
Merge pull request #199 from boostcamp-2020/feature/198
SHIVVVPP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
|
|
||
| # Created by https://www.toptal.com/developers/gitignore/api/swift,xcode,cocoapods | ||
| # Edit at https://www.toptal.com/developers/gitignore?templates=swift,xcode,cocoapods | ||
|
|
||
| ### Swift ### | ||
| # Xcode | ||
| # | ||
| # gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore | ||
|
|
||
| ## User settings | ||
| xcuserdata/ | ||
|
|
||
| ## compatibility with Xcode 8 and earlier (ignoring not required starting Xcode 9) | ||
| *.xcscmblueprint | ||
| *.xccheckout | ||
|
|
||
| ## compatibility with Xcode 3 and earlier (ignoring not required starting Xcode 4) | ||
| build/ | ||
| DerivedData/ | ||
| *.moved-aside | ||
| *.pbxuser | ||
| !default.pbxuser | ||
| *.mode1v3 | ||
| !default.mode1v3 | ||
| *.mode2v3 | ||
| !default.mode2v3 | ||
| *.perspectivev3 | ||
| !default.perspectivev3 | ||
|
|
||
| ## Obj-C/Swift specific | ||
| *.hmap | ||
|
|
||
| ## App packaging | ||
| *.ipa | ||
| *.dSYM.zip | ||
| *.dSYM | ||
|
|
||
| ## Playgrounds | ||
| timeline.xctimeline | ||
| playground.xcworkspace | ||
|
|
||
| # Swift Package Manager | ||
| # Add this line if you want to avoid checking in source code from Swift Package Manager dependencies. | ||
| # Packages/ | ||
| # Package.pins | ||
| # Package.resolved | ||
| # *.xcodeproj | ||
| # Xcode automatically generates this directory with a .xcworkspacedata file and xcuserdata | ||
| # hence it is not needed unless you have added a package configuration file to your project | ||
| # .swiftpm | ||
|
|
||
| .build/ | ||
|
|
||
| # CocoaPods | ||
| # We recommend against adding the Pods directory to your .gitignore. However | ||
| # you should judge for yourself, the pros and cons are mentioned at: | ||
| # https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control | ||
| # Pods/ | ||
| # Add this line if you want to avoid checking in source code from the Xcode workspace | ||
| # *.xcworkspace | ||
|
|
||
| # Carthage | ||
| # Add this line if you want to avoid checking in source code from Carthage dependencies. | ||
| # Carthage/Checkouts | ||
|
|
||
| Carthage/Build/ | ||
|
|
||
| # Accio dependency management | ||
| Dependencies/ | ||
| .accio/ | ||
|
|
||
| # fastlane | ||
| # It is recommended to not store the screenshots in the git repo. | ||
| # Instead, use fastlane to re-generate the screenshots whenever they are needed. | ||
| # For more information about the recommended setup visit: | ||
| # https://docs.fastlane.tools/best-practices/source-control/#source-control | ||
|
|
||
| fastlane/report.xml | ||
| fastlane/Preview.html | ||
| fastlane/screenshots/**/*.png | ||
| fastlane/test_output | ||
|
|
||
| # Code Injection | ||
| # After new code Injection tools there's a generated folder /iOSInjectionProject | ||
| # https://github.com/johnno1962/injectionforxcode | ||
|
|
||
| iOSInjectionProject/ | ||
|
|
||
| ### Xcode ### | ||
| # Xcode | ||
| # gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ## Gcc Patch | ||
| /*.gcno | ||
|
|
||
| ### Xcode Patch ### | ||
| *.xcodeproj/* | ||
| !*.xcodeproj/project.pbxproj | ||
| !*.xcodeproj/xcshareddata/ | ||
| !*.xcworkspace/contents.xcworkspacedata | ||
| **/xcshareddata/WorkspaceSettings.xcsettings | ||
|
|
||
| # End of https://www.toptal.com/developers/gitignore/api/swift,xcode | ||
| .DS_Store | ||
| .DS_Store? | ||
| ._* | ||
| .Spotlight-V100 | ||
| .Trashes | ||
| ehthumbs.db | ||
| Thumbs.db | ||
|
|
||
| ### CocoaPods ### | ||
| ## CocoaPods GitIgnore Template | ||
|
|
||
| # CocoaPods - Only use to conserve bandwidth / Save time on Pushing | ||
| # - Also handy if you have a large number of dependant pods | ||
| # - AS PER https://guides.cocoapods.org/using/using-cocoapods.html NEVER IGNORE THE LOCK FILE | ||
| Pods/ | ||
|
|
||
| *.xcuserstate | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| name: Discussion issue template | ||
| about: 의논사항에 대한 이슈 작성시 사용하는 템플릿 | ||
| title: '' | ||
| labels: "🏷️ discussion 🗨️" | ||
| assignees: whrlgus, SHIVVVPP, seoulboy | ||
|
|
||
| --- | ||
|
|
||
| ### 의논거리 🤔 | ||
| - | ||
|
|
||
| ### 관련 PR or Issue Number | ||
|
|
||
| - PR : | ||
| - Issue : | ||
|
|
||
| ### 이미지 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| name: feature request template | ||
| about: feature 추가시 사용하는 기본 템플릿 | ||
| title: story를 적어주세요 | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| # story를 적어주세요 | ||
|
|
||
| - 필요시 추가 설명 작성 | ||
|
|
||
| ## 완료 조건 ✅ | ||
|
|
||
| - [ ] task1 | ||
| - [ ] task2 | ||
|
|
||
| ## 관련 이슈 📎 | ||
|
|
||
| 관련 이슈 없음 | ||
|
|
||
| ## 레퍼런스 📚 | ||
|
|
||
| 레퍼런스 없음 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| name: Scrum 및 wrap-up issue template | ||
| about: 데일리 스크럼 및 wrap-up 이슈 작성시 사용하는 템플릿 | ||
| title: 'Day 00 Scrum 및 Wrap Up ' | ||
| labels: "daily scrum & Wrap up 👨👩👧👦" | ||
| assignees: whrlgus, SHIVVVPP, seoulboy | ||
|
|
||
| --- | ||
|
|
||
| ## 스크럼 / Wrap-up 택 1 | ||
|
|
||
| 스크럼 템플릿 | ||
|
|
||
| ### 1. 어제 한 일 🌙 | ||
| - ... | ||
| ### 2. 오늘 할 일 🔥 | ||
| - ... | ||
| ### 3. 공유할 이슈 🙌 | ||
| <hr> | ||
|
|
||
| wrap-up 템플릿 | ||
|
|
||
| ### 오늘의 회고 🎈 | ||
| ``` | ||
| 초기 프로젝트 셋팅 때문에 많이들 힘들텐데 열심히 하는모습이 대견하다! | ||
| wiki 정리가 생각보다 많이 길어졌다. wiki를 정리하며, 템플릿을 만드는데 거의 하루종일 소비했다. | ||
| CI/CD 에 대해 진행을 오늘 하루종일 못했다. 내일은 정말 CI/CD를 공부한다!😎 | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| ### Issue Number | ||
| Close # | ||
|
|
||
| ### 변경사항 | ||
|
|
||
| - 의존성 목록 | ||
|
|
||
| ### 새로운 기능 | ||
|
|
||
| - 기능 목록 | ||
|
|
||
| ### 작업 유형 | ||
| - [x] 신규 기능 추가 | ||
| - [ ] 버그 수정 | ||
| - [ ] 리펙토링 | ||
| - [ ] 문서 업데이트 | ||
|
|
||
| ### 체크리스트 | ||
| - [ ] Merge 하는 브랜치가 올바른가? | ||
| - [ ] 코딩컨벤션을 준수하는가? | ||
| - [ ] PR과 관련없는 변경사항이 없는가? | ||
| - [ ] 내 코드에 대한 자기 검토가 되었는가? | ||
| - [ ] 변경사항이 효과적이거나 동작이 작동한다는 것을 보증하는 테스트를 추가하였는가? | ||
| - [ ] 새로운 테스트와 기존의 테스트가 변경사항에 대해 만족하는가? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: iOS CI workflow | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
|
|
||
| build: | ||
| name: Build, Install Pods, and Run Unit Tests | ||
| env: | ||
| SCHEME: "BoostRunClub" | ||
| DEVICE: "iPhone 12" | ||
| WORKSPACE: "BoostRunClub.xcworkspace" | ||
|
|
||
| runs-on: macOS-latest | ||
|
|
||
| steps: | ||
|
|
||
| - name: Checkout project | ||
| uses: actions/checkout@v1 | ||
|
|
||
| - name: CocoaPod Install | ||
| run: pod install | ||
|
|
||
| - name: Select Xcode 12 | ||
| run: sudo xcode-select -switch /Applications/Xcode_12.2.app | ||
|
|
||
| - name: Build | ||
| run: | | ||
| set -eo pipefail && xcodebuild build-for-testing \ | ||
| -scheme $SCHEME \ | ||
| -workspace $WORKSPACE \ | ||
| -destination "platform=iOS Simulator,name=$DEVICE" | | ||
| xcpretty --color --simple | ||
| - name: Run unit tests | ||
| run: | | ||
| set -eo pipefail && xcodebuild test-without-building \ | ||
| -scheme $SCHEME \ | ||
| -workspace $WORKSPACE \ | ||
| -destination "platform=iOS Simulator,name=$DEVICE" | | ||
| xcpretty --color --simple |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
carthage를 사용한 흔적은 없어보이는데 .gitIgnore에 추가되어 있네요!
사소해 보일 수 있지만, .gitIgnore 또한 관리가 필요하답니다 🙂
사용하지 않는 디펜던시에 대한 ignore 명령은 삭제해주세요!
(상단을 보니 gitignore을 생성해주는 웹사이트에서 긁어오신 것 같은데 가급적이면 직접 관리하시는 것을 권장드려요! 🙂)