Skip to content

Commit a89c220

Browse files
committed
Stop touching the echo context after upgrading the connection
1 parent fc3fb4e commit a89c220

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/server/server.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,17 @@ func (s *Server) HandleSubscribe(c echo.Context) error {
9393
return err
9494
}
9595

96+
subIP := c.RealIP()
97+
9698
ws, err := upgrader.Upgrade(c.Response(), c.Request(), nil)
9799
if err != nil {
98100
return err
99101
}
100102
defer ws.Close()
101103

102-
log := slog.With("source", "server_handle_subscribe", "socket_addr", ws.RemoteAddr().String(), "real_ip", c.RealIP())
104+
log := slog.With("source", "server_handle_subscribe", "socket_addr", ws.RemoteAddr().String(), "real_ip", subIP)
103105

104-
sub, err := s.AddSubscriber(ws, c.RealIP(), subscriberOpts)
106+
sub, err := s.AddSubscriber(ws, subIP, subscriberOpts)
105107
if err != nil {
106108
log.Error("failed to add subscriber", "error", err)
107109
return err

0 commit comments

Comments
 (0)