[PM-27001] Skip account selection only one exists on cxp flow #6055
Conversation
…on VerifyPasswordScreen Cross click should cancel the operation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
==========================================
+ Coverage 84.76% 84.79% +0.03%
==========================================
Files 737 732 -5
Lines 55285 55184 -101
Branches 7623 7647 +24
==========================================
- Hits 46861 46795 -66
+ Misses 5764 5712 -52
- Partials 2660 2677 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aj-rosado
requested review from
a team,
brian-livefront and
david-livefront
as code owners
| data object CancelExport : VerifyPasswordEvent() | ||
|
|
||
| /** | ||
| * Show a snackbar with the given data . |
There was a problem hiding this comment.
Can you drop the extra space before the period
| @IgnoredOnParcel | ||
| val input: String = "", | ||
| val dialog: DialogState? = null, | ||
| val showResendCodeButton: Boolean = false, |
There was a problem hiding this comment.
Can you fix this formatting
| specialCircumstance is SpecialCircumstance.CredentialExchangeExport -> { | ||
| RootNavState.CredentialExchangeExport | ||
| if (userState.accounts.size == 1) { | ||
| RootNavState.CredentialExchangeExportSkipAccountSelection(userId = userState.accounts.first().userId) |
There was a problem hiding this comment.
Is this hitting the line limit?
There was a problem hiding this comment.
It was, I have removed the MaxLineLength suppresion and formatted it
| */ | ||
| val isContinueButtonEnabled: Boolean | ||
| get() = input.isNotBlank() && dialog !is DialogState.Loading | ||
| get() = input.isNotBlank() && dialog !is DialogState.Loading |
There was a problem hiding this comment.
The previous formatting was correct
| .completeCredentialExport( | ||
| exportResult = ExportCredentialsResult.Failure( | ||
| error = ImportCredentialsCancellationException( | ||
| errorMessage = "User cancelled import.", |
There was a problem hiding this comment.
Does this message get displayed anywhere?
There was a problem hiding this comment.
yes, it appears on the error stacktrace of the app that is trying to import.
There was a problem hiding this comment.
OK, I wasn't sure if we needed this to be localized. If it's just part of the stacktrace, this is fine.
|
thanks @david-livefront |
aj-rosado
deleted the
PM-27001/skip-account-selection-only-one-exist-cxp
branch
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27001
📔 Objective
If the user only has one account, it should skip the account selection screen and go directly to the verify password on the CXP.
When the user has no other accounts, verify password screen should have a ❌ on the top left instead of a back arrow and should cancel the operation returning to the original app.
📸 Screenshots
Screen.Recording.2025-10-20.at.15.42.14.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes