-
-
Notifications
You must be signed in to change notification settings - Fork 253
Add MAUI .NET 10 RC 2 improvements to projects (#11560) #11561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdates MAUI projects to adopt .NET 10 RC 2 features by removing explicit XAML compile-time attributes, configuring source generation-based XAML inflator, disabling Mono runtime in Android publishing, and updating CI/CD artifact export. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (5)
.github/workflows/admin-sample.cd.yml(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/App.xaml.cs(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/App.xaml.cs(0 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj(2 hunks)
💤 Files with no reviewable changes (1)
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/App.xaml.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: build api + blazor web
- GitHub Check: build blazor hybrid (windows)
- GitHub Check: build blazor hybrid (android)
- GitHub Check: build blazor wasm standalone (small)
- GitHub Check: build blazor hybrid (iOS-macOS)
- GitHub Check: build api + blazor web
- GitHub Check: build blazor wasm standalone (AOT)
- GitHub Check: build blazor hybrid (windows)
- GitHub Check: build api + blazor web
- GitHub Check: build api + blazor web
- GitHub Check: build blazor hybrid (windows)
- GitHub Check: build api + blazor web
- GitHub Check: build blazor hybrid (iOS-macOS)
- GitHub Check: build blazor hybrid (android)
- GitHub Check: build and test
- GitHub Check: build blazor hybrid (iOS-macOS)
- GitHub Check: build blazor hybrid (android)
- GitHub Check: build blazor wasm standalone
- GitHub Check: build and test
🔇 Additional comments (4)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/App.xaml.cs (1)
1-11: LGTM! Correctly removes obsolete XAML compilation attribute.The removal of
[assembly: XamlCompilation(XamlCompilationOptions.Compile)]is appropriate when using the new source generation-based XAML inflator. This attribute is no longer needed and would conflict with theMauiXamlInflatorset toSourceGenin the project file.src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Boilerplate.Client.Maui.csproj (1)
12-12: ✓ Verified: XamlCompilation attribute correctly removed, MAUI source generation migration complete.The
App.xaml.csfile has been properly updated—the[assembly: XamlCompilation]attribute is not present. The addition of<MauiXamlInflator>SourceGen</MauiXamlInflator>in the.csprojfile is correctly paired with this removal, completing the migration to .NET MAUI 10 RC 2's source generation-based XAML compilation..github/workflows/admin-sample.cd.yml (2)
307-307: MAUI .NET 10 RC 2 improvement: Mono runtime disabled for Android publishing.The addition of
-p:UseMonoRuntime=falsecorrectly applies the .NET 10 RC 2 enhancement for Android AAB publishing, aligning with the PR objectives. The parameter is properly positioned in the publish command targetingnet10.0-android.
309-313: Glob pattern*-Signed.*is correct and consistently applied across workflows.Verification confirms the artifact upload configuration is appropriate. When you run dotnet publish for a .NET MAUI Android app, the produced bundle gets a "-Signed" suffix, with signed artifacts named as {packageId}-Signed.aab. The glob pattern in line 313 correctly captures this naming convention. The same pattern is consistently used in related workflows (todo-sample.cd.yml, blazorui.demo.cd.yml), and the publish command on line 307 enables signing with
-p:AndroidKeyStore=true, confirming the signed artifact will be produced as expected.
closes #11560
Summary by CodeRabbit