feat!: remove search_mode, unify browse loop with max_pages budget

BREAKING CHANGE: search_mode config key removed. Existing configs are
auto-migrated on startup — the key is silently dropped.

- Remove search_mode from config (MetacriticPlatformConfig), scheduler, and
  pipeline (AcquisitionConfig, run_acquisition, all helper signatures)
- Consolidate pending_games_backlog + pending_games_latest into single
  pending_games table with startup migration (INSERT OR IGNORE + DROP)
- Merge all 10 _backlog/_latest DB method pairs into unified methods
  targeting PendingGame
- Collapse backlog/latest browse branching into single unified loop with
  max_pages budget, max_cycle_pages pacing, progress tracking, and
  infinite auto-reset to page 1 when budget exhausted
- Remove five _by_mode dispatch helpers; callers use db.* directly
- Fix infinite-retry on exhausted browse pages (max(last_page, start_page))
- Remove dead platform param from get_known_slugs
- Update README, config migration, and 797 tests
- Bump version to 3.0.0

Author: binhex

README.md

@@ -170,9 +170,8 @@ download_sites:
 | `min_metascore_reviews` | Minimum number of critic reviews required. | `10` |
 | `min_user_score` | Minimum Metacritic user score (0–10). | `7.5` |
 | `min_user_reviews` | Minimum number of user reviews required. | `10` |
-| `search_mode` | Scanning mode: `"backlog"` (historical deep scan) or `"latest"` (recent releases only). | `"latest"` |
-| `max_pages` | In `"backlog"` mode: total browse page window depth. The scanner progressively advances through `max_pages` pages across cycles. In `"latest"` mode: ignored. `0` = unlimited. | `500` |
-| `max_cycle_pages` | In `"backlog"` mode: max pages per cycle (pacing). In `"latest"` mode: the window of recent pages to scan (always pages 1-N). `0` = unlimited. | `0` |
+| `max_pages` | Total browse page depth budget. The scanner progressively advances through pages across cycles. When the budget is exhausted, scanning resets to page 1. `0` = unlimited. | `500` |
+| `max_cycle_pages` | Maximum pages per cycle (pacing). `0` = unlimited. | `0` |
 | `sort_order` | Browse sort order: `"new"` (release date) or `"metascore"` (by critic score). | `"new"` |
 | `max_queue_days` | Days a game stays in the pending queue before expiring. `0` = indefinite pending (no expiry). | `30` |
 | `enabled` | Enable or disable the Metacritic browse step. Disabling skips game discovery entirely. | `true` |
@@ -301,7 +300,7 @@ flowchart TD
    are skipped. `max_cycle_pages` controls the per-cycle page limit
    (default `0` = unlimited). The scanner advances through the
    `max_pages` window progressively — each cycle resumes where the
-   last one left off, draining the backlog page by page.
+   last one left off, with auto-reset to page 1 when the `max_pages` budget is exhausted.
    **Note:** browse scores are on a different scale and always
    exceed the configured thresholds — score filtering effectively starts
    at the verification step (phase 4), not here.

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "gamarr"
-version = "2.1.2"
+version = "3.0.0"
 description = "Metadata game downloader - torrent metadata harvester"
 readme = "README.md"
 requires-python = ">=3.12"

src/gamarr/config.py

@@ -13,7 +13,7 @@
     from collections.abc import Iterator
 
 
-_CONFIG_VERSION = "1.0.0"
+_CONFIG_VERSION = "1.58.0"
 _CONFIG_FILENAME = "gamarr.yml"
 
 
@@ -111,7 +111,6 @@ class MetacriticPlatformConfig(BaseModel):
     max_pages: int = Field(default=500, ge=1)
     max_cycle_pages: int | None = Field(default=0, ge=0)
     sort_order: Literal["new", "metascore"] = "new"
-    search_mode: Literal["backlog", "latest"] = "latest"
     reject_genre: list[str] = Field(default_factory=list)
     reject_title: list[str] = Field(default_factory=list)  # case-insensitive substrings
 
@@ -800,6 +799,25 @@ def _upgrade_freegog_entry(fg: dict[str, Any], defaults: dict[str, Any]) -> bool
     return True
 
 
+def _migrate_remove_search_mode(raw: dict[str, Any]) -> bool:
+    """Remove deprecated search_mode from metacritic platform overrides.
+
+    search_mode is no longer needed — the browse loop is unified.
+    Returns True if any search_mode keys were removed.
+    """
+    changed = False
+    overrides = raw.get("review_sites", {}).get("metacritic", {}).get("platform_overrides", {})
+    for platform_key, platform_config in overrides.items():
+        if isinstance(platform_config, dict) and "search_mode" in platform_config:
+            del platform_config["search_mode"]
+            logger.info(
+                "Config: removed deprecated 'search_mode' from platform '{}' — browse loop is unified",
+                platform_key,
+            )
+            changed = True
+    return changed
+
+
 def _migrate_config(raw: dict[str, Any]) -> bool:
     """Migrate renamed config keys in-place for all platforms.
 
@@ -834,6 +852,7 @@ def _migrate_config(raw: dict[str, Any]) -> bool:
             _migrate_daemon_mode,
             _migrate_add_post_process_path_case,
             _migrate_add_freegog_to_download_sites,
+            _migrate_remove_search_mode,
         ]
         for fn in _migrations:
             if fn(raw):