Convert global browser bindings to functions

Author: bikallem

docs/wasm-gc-codegen.md

@@ -317,7 +317,7 @@ Without disambiguation, duplicate JS object keys cause the last one to silently
 |---------------|-----------|--------|-------------|
 | `js_value.mbt` | `js_value.mbt` (type, trait, `unsafe_cast`) | `js_value_js.mbt` (`extern "js"` for undefined/null/isNull, `js_of`) | `js_value_wasm.mbt` (wasm imports, `jsvalue_to_string` workaround) |
 | `primitives.mbt` | — | `primitives_js.mbt` (all `%identity`) | `primitives_wasm.mbt` (FFI calls for value types, `%identity` for String) |
-| `global.mbt` | `global.mbt` (`pub let document/window/navigator`) | `global_js.mbt` (`extern "js"` FFI) | `global_wasm.mbt` (wasm imports) |
+| `global.mbt` | `global.mbt` (`pub fn document()/window()/navigator()`) | `global_js.mbt` (`extern "js"` FFI) | `global_wasm.mbt` (wasm imports) |
 
 Files that needed no splitting (already cross-target compatible):
 - `js_array.mbt` — uses `= "JsArray" "empty"` syntax

webapi/README.mbt.md

@@ -78,7 +78,7 @@ fn readme_counter() -> Unit {
   let mut count = 0
 
   // Create count display element
-  let count_display : HTMLDivElement = document.create_element("div").into()
+  let count_display : HTMLDivElement = document().create_element("div").into()
   count_display
   ..set_attribute("id", "count-display")
   .set_attribute("style", "font-size: 3em; margin: 0.5em 0;")
@@ -89,15 +89,15 @@ fn readme_counter() -> Unit {
   }
 
   // Create increment button — closures are accepted directly
-  let increment_btn = document.create_element("button")
+  let increment_btn = document().create_element("button")
   increment_btn.set_text_content("+")
   increment_btn.add_event_listener("click", fn(_event) {
     count = count + 1
     update_display()
   })
 
   // Append to DOM
-  let app : Element = document.get_element_by_id("app")
+  let app : Element = document().get_element_by_id("app")
   app.append_child(count_display) |> ignore
   app.append_child(increment_btn) |> ignore
 }
@@ -129,10 +129,10 @@ Demonstrates the Canvas 2D API with gradients, shapes, and text:
 ```moonbit nocheck
 ///|
 fn readme_canvas() -> Unit {
-  let canvas : HTMLCanvasElement = document.create_element("canvas").into()
+  let canvas : HTMLCanvasElement = document().create_element("canvas").into()
   canvas.set_width(800)
   canvas.set_height(500)
-  let app : Element = document.get_element_by_id("app")
+  let app : Element = document().get_element_by_id("app")
   app.append_child(canvas) |> ignore
 
   // Get 2D rendering context
@@ -214,19 +214,19 @@ npx serve .
 
 ### Global Objects
 
-The library provides direct access to browser global objects:
+The library provides zero-argument accessors for browser global objects:
 
 ```moonbit nocheck
 ///|
 fn readme_globals() -> Unit {
   // Access the document object
-  let _ = document.get_element_by_id("my-id")
+  let _ = document().get_element_by_id("my-id")
 
   // Access the window object
-  let _ = window.inner_width()
+  let _ = window().inner_width()
 
   // Access the navigator object
-  let _ = navigator.user_agent()
+  let _ = navigator().user_agent()
 }
 ```
 
@@ -238,7 +238,7 @@ DOM elements are returned as generic `Element` types. Use `into()` to cast to sp
 ///|
 fn readme_casting() -> Unit {
   // Create an element and cast to specific type
-  let canvas : HTMLCanvasElement = document.create_element("canvas").into()
+  let canvas : HTMLCanvasElement = document().create_element("canvas").into()
 
   // Cast to access type-specific methods
   let _ctx : CanvasRenderingContext2D = canvas.get_context("2d").unwrap().into()
@@ -256,18 +256,18 @@ Methods that return a nullable interface type (e.g., `Element?`) have two varian
 ///|
 fn readme_opt_methods() -> Unit {
   // Convenience: returns Element directly (panics if not found)
-  let app = document.get_element_by_id("app")
+  let app = document().get_element_by_id("app")
 
   // Cast to a specific subtype with .into():
-  let canvas : HTMLCanvasElement = document
+  let canvas : HTMLCanvasElement = document()
     .get_element_by_id("my-canvas")
     .into()
 
   // Works on subtypes too (e.g., ShadowRoot inherits query_selector from trait):
   // shadow.query_selector("[data-ref=display]")
 
   // _opt variant: returns Option for null-checking
-  match document.get_element_by_id_opt("maybe-missing") {
+  match document().get_element_by_id_opt("maybe-missing") {
     Some(el) => el.set_text_content("found")
     None => ()
   }
@@ -284,7 +284,7 @@ Event listeners and handlers accept closures directly:
 ```moonbit nocheck
 ///|
 fn readme_events() -> Unit {
-  let element = document.create_element("button")
+  let element = document().create_element("button")
 
   // addEventListener with closure
   element.add_event_listener("click", fn(_event) { println("Clicked!") })
@@ -298,7 +298,7 @@ Use `JsPromise` to chain async operations like `fetch()`:
 ```moonbit nocheck
 ///|
 fn readme_promises() -> Unit {
-  window
+  window()
   .fetch("https://api.example.com/data")
   .then(fn(response : Response) {
     response.text().then(fn(text : String) { Console::log([text]) }) |> ignore
@@ -313,7 +313,7 @@ On the JS backend, the `bikallem/webapi/js_promise` subpackage bridges `JsPromis
 ```moonbit nocheck
 ///|
 async fn readme_fetch_async(url : String) -> Unit {
-  let response : Response = @js_promise.to_async_promise(window.fetch(url)).wait()
+  let response : Response = @js_promise.to_async_promise(window().fetch(url)).wait()
   let text : String = @js_promise.to_async_promise(response.text()).wait()
   Console::log([text])
 }
@@ -353,7 +353,7 @@ Most setter methods return `Unit`, enabling method chaining with `..` (use `.` f
 ```moonbit nocheck
 ///|
 fn readme_chaining() -> Unit {
-  let element = document.create_element("div")
+  let element = document().create_element("div")
   element..set_attribute("id", "my-element").set_attribute("class", "container")
   element.set_text_content("Hello!")
 }
@@ -366,10 +366,10 @@ Many methods have optional parameters using MoonBit's `?` syntax:
 ```moonbit nocheck
 fn readme_optional() -> Unit {
   // With default options
-  let _ = document.create_element("div")
+  let _ = document().create_element("div")
 
   // With explicit options
-  let _ = document.create_element(
+  let _ = document().create_element(
     "div",
     options=ElementCreationOptions::new(is="custom-div"),
   )

webapi/global.mbt

@@ -1,13 +1,19 @@
 // MoonBit bindings for global objects
 
 ///|
-pub let document : Document = global_document_ffi()
+pub fn document() -> Document {
+  global_document_ffi()
+}
 
 ///|
-pub let window : Window = global_window_ffi()
+pub fn window() -> Window {
+  global_window_ffi()
+}
 
 ///|
-pub let navigator : Navigator = global_navigator_ffi()
+pub fn navigator() -> Navigator {
+  global_navigator_ffi()
+}
 
 ///|
 #cfg(target="js")

webapi/pkg.generated.mbti

@@ -340,11 +340,11 @@ pub const X_PATH_RESULT_UNORDERED_NODE_SNAPSHOT_TYPE : UInt = 6
 
 pub fn define_custom_element(String, (HTMLElement) -> Unit, on_connected? : (HTMLElement) -> Unit, on_disconnected? : (HTMLElement) -> Unit, on_adopted? : (HTMLElement) -> Unit, on_attribute_changed? : (HTMLElement, String, JsValue, JsValue) -> Unit, observed_attributes? : Array[String]) -> Unit
 
-pub let document : Document
+pub fn document() -> Document
 
-pub let navigator : Navigator
+pub fn navigator() -> Navigator
 
-pub let window : Window
+pub fn window() -> Window
 
 // Errors
 

webapi_gen/base.mbt/global.mbt

@@ -1,10 +1,16 @@
 // MoonBit bindings for global objects
 
 ///|
-pub let document : Document = global_document_ffi()
+pub fn document() -> Document {
+  global_document_ffi()
+}
 
 ///|
-pub let window : Window = global_window_ffi()
+pub fn window() -> Window {
+  global_window_ffi()
+}
 
 ///|
-pub let navigator : Navigator = global_navigator_ffi()
+pub fn navigator() -> Navigator {
+  global_navigator_ffi()
+}