Merge branch 'main' into feature/1865-dont-chop-lambda

Author: belav

Src/CSharpier.Cli/DotIgnore/IgnoreRule.cs

@@ -54,7 +54,18 @@ public IgnoreRule(string pattern)
         {
             var rxOptions = RegexOptions.Compiled;
 
-            this.regex = new Regex(rxPattern, rxOptions);
+            try
+            {
+                this.regex = new Regex(rxPattern, rxOptions);
+            }
+            catch (RegexParseException ex)
+                when (ex.Message
+                    == "Invalid pattern '^Icon(?!/)[$' at offset 12. Unterminated [] set."
+                )
+            {
+                // old macOS uses 'Icon\r' in folder names, which needs this in a .gitignore Icon[\r]\n
+                // instead of dealing with that, just don't treat this line as regex
+            }
         }
     }
 

Src/CSharpier.Generators/CSharpier.Generators.csproj

@@ -5,7 +5,7 @@
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
     <PackageScribanIncludeSource>true</PackageScribanIncludeSource>
     <LangVersion>13</LangVersion>
-    <NoWarn>SYSLIB0013;NU1903</NoWarn>
+    <NoWarn>SYSLIB0013;NU1903;NU1902</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.Common" />

Src/CSharpier.Tests/Cli/IgnoreFileTests.cs

@@ -595,6 +595,13 @@ public void Range()
         );
     }
 
+    [Test]
+    public void MacOs()
+    {
+        // we can't actually test a folder name with \r in it, but this makes sure that we at least parse it
+        this.GitBasedTest("# General\nBin\nIcon[\r]\nObj\n", ["Bin/file.txt", "Obj/file.txt"]);
+    }
+
     // TODO this passes because the ignorefile says the file is not ignored
     [Test]
     public void Thing()