use env slack_channel_id

geoffhouse · geoffhouse · commit 12820fa6460c · 2026-06-09T11:07:09.000+01:00
diff --git a/.github/actions/slack-run-finish/action.yml b/.github/actions/slack-run-finish/action.yml
@@ -2,9 +2,6 @@ name: Slack Run Finish
 description: Update a posted workflow Slack message with final status color, or delete it when skipped.
 
 inputs:
-    channel_id:
-        description: Slack channel id returned by start action.
-        required: true
     ts:
         description: Slack message timestamp returned by start action.
         required: true
@@ -49,7 +46,7 @@ runs:
               method: chat.delete
               token: ${{ env.SLACK_BOT_TOKEN }}
               payload: |
-                  channel: ${{ inputs.channel_id }}
+                  channel: ${{ env.SLACK_CHANNEL_ID }}
                   ts: ${{ inputs.ts }}
 
         - name: Update message
@@ -59,7 +56,7 @@ runs:
               method: chat.update
               token: ${{ env.SLACK_BOT_TOKEN }}
               payload: |
-                  channel: ${{ inputs.channel_id }}
+                  channel: ${{ env.SLACK_CHANNEL_ID }}
                   ts: ${{ inputs.ts }}
                   attachments:
                     - color: "${{ steps.style.outputs.color }}"
diff --git a/.github/actions/slack-run-start/action.yml b/.github/actions/slack-run-start/action.yml
@@ -12,9 +12,6 @@ inputs:
         default: "#1d4ed8"
 
 outputs:
-    channel_id:
-        description: Slack channel id for the posted message.
-        value: ${{ steps.extract.outputs.channel_id }}
     ts:
         description: Slack message timestamp for updates.
         value: ${{ steps.extract.outputs.ts }}
@@ -45,19 +42,13 @@ runs:
           env:
               SLACK_RESPONSE: ${{ steps.post.outputs.response }}
               SLACK_TS: ${{ steps.post.outputs.ts }}
-              SLACK_CHANNEL_ID: ${{ steps.post.outputs.channel_id }}
           run: |
               ts="$SLACK_TS"
-              channel_id="$SLACK_CHANNEL_ID"
 
               if [[ -n "$SLACK_RESPONSE" && "$SLACK_RESPONSE" != "null" ]]; then
                   if [[ -z "$ts" ]]; then
                       ts=$(echo "$SLACK_RESPONSE" | jq -r '.ts // empty')
                   fi
-                  if [[ -z "$channel_id" ]]; then
-                      channel_id=$(echo "$SLACK_RESPONSE" | jq -r '.channel_id // .channel // empty')
-                  fi
               fi
 
               echo "ts=$ts" >> "$GITHUB_OUTPUT"
-              echo "channel_id=$channel_id" >> "$GITHUB_OUTPUT"
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -133,10 +133,9 @@ jobs:
                       uk.co.bbc.bug.build.commit=${{ github.sha }}
 
             - name: update slack message
-              if: ${{ always() && steps.slack-start.outputs.ts != '' && steps.slack-start.outputs.channel_id != '' }}
+              if: ${{ always() && steps.slack-start.outputs.ts != '' }}
               uses: ./.github/actions/slack-run-finish
               with:
-                  channel_id: ${{ steps.slack-start.outputs.channel_id }}
                   ts: ${{ steps.slack-start.outputs.ts }}
                   status: ${{ job.status }}
                   message_prefix: Deployment
diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml
@@ -34,7 +34,6 @@ jobs:
         name: Slack start message
         runs-on: ubuntu-latest
         outputs:
-            channel_id: ${{ steps.slack-start.outputs.channel_id }}
             ts: ${{ steps.slack-start.outputs.ts }}
         steps:
             - name: checkout repository
@@ -46,7 +45,6 @@ jobs:
               with:
                   message_prefix: Workflow running
 
-    # spell check documentation
     codespell:
         runs-on: ubuntu-latest
         steps:
@@ -60,7 +58,6 @@ jobs:
                   only_warn: 1
                   ignore_words_list: aoto,daa,te
 
-    # build storybook
     storybook:
         runs-on: ubuntu-latest
         steps:
@@ -81,7 +78,6 @@ jobs:
                   name: storybook
                   path: src/client/storybook-static
 
-    # build jekyll docs and include storybook + modules
     pages:
         runs-on: ubuntu-latest
         needs: storybook
@@ -95,23 +91,19 @@ jobs:
                   name: storybook
                   path: storybook-static
 
-            # merge storybook into docs folder before Jekyll build
             - name: Add Storybook to docs
               run: |
                   mkdir -p docs/storybook
                   cp -a storybook-static/* docs/storybook/
 
-            # setup node (needed to run modules generator)
             - name: Setup Node
               uses: actions/setup-node@v3
               with:
                   node-version: 20
 
-            # install dependencies for modules script (js-yaml, etc.)
             - name: Install Dependencies
               run: npm ci
 
-            # generate modules pages before building site
             - name: Generate Modules Pages
               run: node docs/scripts/generateModules.js
 
@@ -129,7 +121,6 @@ jobs:
               with:
                   path: ./_site
 
-    # deploy to github pages
     deploy:
         needs: pages
         runs-on: ubuntu-latest
@@ -143,7 +134,7 @@ jobs:
 
     slack-finish:
         name: Slack final status
-        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' && needs.slack-start.outputs.channel_id != '' }}
+        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' }}
         needs:
             - slack-start
             - codespell
@@ -171,7 +162,6 @@ jobs:
             - name: update slack message
               uses: ./.github/actions/slack-run-finish
               with:
-                  channel_id: ${{ needs.slack-start.outputs.channel_id }}
                   ts: ${{ needs.slack-start.outputs.ts }}
                   status: ${{ steps.workflow-status.outputs.status }}
                   message_prefix: Workflow
diff --git a/.github/workflows/test-bug-client.yml b/.github/workflows/test-bug-client.yml
@@ -48,10 +48,9 @@ jobs:
             - run: cd src/client && npm run build --if-present
 
             - name: update slack message
-              if: ${{ always() && steps.slack-start.outputs.ts != '' && steps.slack-start.outputs.channel_id != '' }}
+              if: ${{ always() && steps.slack-start.outputs.ts != '' }}
               uses: ./.github/actions/slack-run-finish
               with:
-                  channel_id: ${{ steps.slack-start.outputs.channel_id }}
                   ts: ${{ steps.slack-start.outputs.ts }}
                   status: ${{ job.status }}
                   message_prefix: Workflow
diff --git a/.github/workflows/test-bug-server.yml b/.github/workflows/test-bug-server.yml
@@ -49,10 +49,9 @@ jobs:
               run: npm run test:server
 
             - name: update slack message
-              if: ${{ always() && steps.slack-start.outputs.ts != '' && steps.slack-start.outputs.channel_id != '' }}
+              if: ${{ always() && steps.slack-start.outputs.ts != '' }}
               uses: ./.github/actions/slack-run-finish
               with:
-                  channel_id: ${{ steps.slack-start.outputs.channel_id }}
                   ts: ${{ steps.slack-start.outputs.ts }}
                   status: ${{ job.status }}
                   message_prefix: Workflow
diff --git a/.github/workflows/test-module-container.yml b/.github/workflows/test-module-container.yml
@@ -22,7 +22,6 @@ jobs:
         name: Slack start message
         runs-on: ubuntu-latest
         outputs:
-            channel_id: ${{ steps.slack-start.outputs.channel_id }}
             ts: ${{ steps.slack-start.outputs.ts }}
         steps:
             - name: checkout repository
@@ -219,7 +218,7 @@ jobs:
 
     slack-finish:
         name: Slack final status
-        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' && needs.slack-start.outputs.channel_id != '' }}
+        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' }}
         needs:
             - slack-start
             - discover-modules
@@ -247,7 +246,6 @@ jobs:
             - name: update slack message
               uses: ./.github/actions/slack-run-finish
               with:
-                  channel_id: ${{ needs.slack-start.outputs.channel_id }}
                   ts: ${{ needs.slack-start.outputs.ts }}
                   status: ${{ steps.workflow-status.outputs.status }}
                   message_prefix: Workflow
diff --git a/.github/workflows/versioning.yml b/.github/workflows/versioning.yml
@@ -30,7 +30,6 @@ jobs:
         name: Slack start message
         runs-on: ubuntu-latest
         outputs:
-            channel_id: ${{ steps.slack-start.outputs.channel_id }}
             ts: ${{ steps.slack-start.outputs.ts }}
         steps:
             - name: checkout repository
@@ -138,7 +137,7 @@ jobs:
 
     slack-finish:
         name: Slack final status
-        if: ${{ always() && needs.slack-start.outputs.ts != '' && needs.slack-start.outputs.channel_id != '' }}
+        if: ${{ always() && needs.slack-start.outputs.ts != '' }}
         needs:
             - slack-start
             - verify-tests
@@ -164,7 +163,6 @@ jobs:
             - name: update slack message
               uses: ./.github/actions/slack-run-finish
               with:
-                  channel_id: ${{ needs.slack-start.outputs.channel_id }}
                   ts: ${{ needs.slack-start.outputs.ts }}
                   status: ${{ steps.workflow-status.outputs.status }}
                   message_prefix: Workflow
