Skip to content

Commit ca44e5b

Browse files
committed
Fix and re-format stack trace output
1 parent 830a162 commit ca44e5b

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

background.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ function handleInitRequest(data, sender, sendResponse) {
9090

9191
function handleErrorsRequest(data, sender, sendResponse) {
9292
var popupErrors = [];
93-
var stackLineRegExp = new RegExp('^(.*?)\\(?((https?|file)://.*?)(\\)|$)');
9493
var tabHost = getBaseHostByUrl(data.url);
9594
var tabBaseUrl = (/^([\w-]+:\/\/[^\/?]+)/.exec(data.url) || [null, null])[1];
9695

@@ -127,14 +126,13 @@ function handleErrorsRequest(data, sender, sendResponse) {
127126
if(localStorage['showTrace'] && error.stack && (lines = error.stack.replace(/\n\s*at\s+/g, '\n').split('\n')).length > 2) {
128127
lines.shift();
129128
for(var ii in lines) {
130-
var m = stackLineRegExp.exec(lines[ii]);
129+
var m = /^(.*?)\(?(([\w-]+):\/\/.*?)(\)|$)/.exec(lines[ii]);
131130
var url = m ? m[2] : lines[ii];
132131
var subUrl = (localStorage['showColumn'] ? /^(.*?):([\d:]+)$/ : /^(.*?):(\d+)(:\d+)?$/).exec(url);
133-
var num = lines.length - ii;
134-
var url = subUrl ? subUrl[1] : url;
135132
var line = subUrl ? subUrl[2] : null;
136133
var method = (m && m[1].trim() ? m[1].trim() + '()' : '');
137-
errorHtml += '<br/>' + ((lines.length > 1 ? '&nbsp;#' + num + ' ' : '') + (localStorage['linkViewSource']
134+
url = subUrl ? subUrl[1] : url;
135+
errorHtml += '<br/>&nbsp;' + ((localStorage['linkViewSource']
138136
? ('<a href="view-source:' + url + (line ? '#' + line : '') + '" target="_blank">' + url + (line ? ':' + line : '') + '</a>')
139137
: (url + (line ? ':' + line : ''))
140138
) + ' ' + method);
@@ -143,7 +141,7 @@ function handleErrorsRequest(data, sender, sendResponse) {
143141
}
144142
else {
145143
var url = error.url + (error.line ? ':' + error.line : '');
146-
errorHtml += '<br/>' + (localStorage['linkViewSource']
144+
errorHtml += '<br/>&nbsp;' + (localStorage['linkViewSource']
147145
? '<a href="view-source:' + error.url + (error.line ? '#' + error.line : '') + '" target="_blank">' + url + '</a>'
148146
: url);
149147
}

0 commit comments

Comments
 (0)