Fix the replay marker export #3740
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTimo
changed the title
-rdynamic is a big hammer that shouldn't be necessary here.
TTimo
force-pushed
the
fix-symbol-export-without-rdynamic
branch
from
6bc6999 to
3776e97
Compare
Owner
|
It's not clear why this problem exists as I can't reproduce it, but it was fixed by #3734 which was merged a little while ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the replay marker export with a link script for clang and a switch to 'externally_visible' attribute for gcc, instead of -rdynamic.
-rdynamic is a big hammer that shouldn't be necessary here.