[Help needed] `Shadowstep` false positive

[Synful-Syn]

Current Behaviour

Added during #114

The spell Shadowstep may cause a speed hack false positive when used from far. Read the comments below.

mod-anticheat/src/AnticheatMgr.cpp

Lines 157 to 172 in 3177f5d

	float AnticheatMgr::GetTeleportSkillDistanceInYards(Player* player) const
	{
	switch (player->getClass())
	{
	case CLASS_ROGUE: // The rogue's teleport spell is Shadowstep.
	return 25.0f; // Synful-Syn: Help needed! At least, 25 yards adjustment is better than nothing!
	// The spell can be casted at a maximum of 25 yards from the middle of the ennemy and teleports the player a short distance behind the target which might be over 25 yards, especially when the target is facing the rogue.
	// Using Shadowstep on Onyxia at as far as I could moved me by 44 yards. Doing it on a blood elf in duel moved me 29 yards.
	case CLASS_MAGE: // The mage's teleport spell is Blink.
	if (player->HasAura(GLYPH_OF_BLINK))
	return 25.1f; // Includes a 0.1 miscalculation margin.
	return 20.1f; // Includes a 0.1 miscalculation margin.
	default:
	return 0.0f;
	}
	}

Expected Blizzlike Behaviour

Uhh... no false positive from Shadowstep!

Steps to reproduce the problem

On a non-gm, move in front of front of Onyxia at max range.
Use Shadowstep.
Use the GM command .anticheat player at the player, the countermeasure counter should have raised up.

Extra Notes

Does happen with 3177f5d
Still used to happen back on cd50405

AC rev. hash/commit

AzerothCore rev. 0c52476b1d37 2023-06-08 19:35:13 +0000 (master branch) (Win64, RelWithDebInfo, Static)
Using SSL version: OpenSSL 1.1.1m 14 Dec 2021 (library: OpenSSL 1.1.1m 14 Dec 2021)
Using Boost version: 1.82.0
Using MySQL version: 80027
Using CMake version: 3.22.1
Compiled on: Windows 10.0.19044
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 291014951 bytes
vmaps directory located in ./vmaps. Total size: 658130721 bytes
mmaps directory located in ./mmaps. Total size: 2192910844 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: ACDB 335.10-dev
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0

List enable modules:

• mod-anticheat

Operating system

Windows 10 x64