Feature: UseBuyPriceForSeller same TradeGoods didn't appear in Seller [bug] Add Use Buy-and-Sell PriceForSeller

[cesuogui]

Describe your feature request or suggestion in detail

If UseBuyPriceForSeller =0 the TradeGoods 【Ink of the Sea】 can appear in Seller

But if UseBuyPriceForSeller =1 【Ink of the Sea 】 didn't appear in Seller ， but 【Infinite Dust 】 will appear in AH

Same TradeGoods only have BuyPrice or SellPrice such as 【Strange Dust】 only can buy from NPC but can't Sell to NPC

Describe a possible solution to your feature or suggestion in detail

UseBuyPriceForSeller first and if the TradeGoods didn't have BuyPrice use SellPrice make 【Ink of the Sea】 and 【Infinite Dust 】can appear together in AH

Additional context

AuctionHouseBot.UseBuyPriceForSeller_first_then_UseSellPriceForSeller =1

[kewinrausch]

Hi, can you provide one example of such item to explore the issue?

[cesuogui]

Hi, can you provide one example of such item to explore the issue?

sorry I use the < x >mark the item name , it can't show
UseBuyPriceForSeller =0 AH appear in Seller【Snowfall Ink】【Ink of the Sea】【Celestial Ink】
UseBuyPriceForSeller =1 AH appear in Seller 【Arcane Dust】【Infinite Dust 】 【Strange Dust】

They cannot be sold by AHbots in the auction house at the same time

[kewinrausch]

Those items does have the prices set at 0 stright from the database, meaning you can't be able to usually buy/sell.
For example, Snowfall Ink:

select * from item_template where name like '%Snowfall Ink%';
+-------+-------+----------+-----------------------+--------------+-----------+---------+-------+------------+----------+----------+-----------+---------------+----------------+---------------+-----------+---------------+---------------+-------------------+---------------+-------------------+------------------+---------------------------+------------------------+----------+-----------+----------------+------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+-------------+--------------+-------------------------+------------------+----------+----------+-----------+----------+----------+-----------+-------+----------+----------+------------+-----------+------------+------------+-------+-----------+----------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+---------+-------------+----------+------------+--------------+------------+--------+----------+--------+----------------+--------------+-------+---------+---------------+------+-----+-----------+---------------+---------------+-----------------+---------------+-----------------+---------------+-----------------+-------------+---------------+-------------------------+---------------------+----------+-------------------+-----------+------------+--------------+----------+--------------+--------------+-------------+---------------+
| entry | class | subclass | SoundOverrideSubclass | name         | displayid | Quality | Flags | FlagsExtra | BuyCount | BuyPrice | SellPrice | InventoryType | AllowableClass | AllowableRace | ItemLevel | RequiredLevel | RequiredSkill | RequiredSkillRank | requiredspell | requiredhonorrank | RequiredCityRank | RequiredReputationFaction | RequiredReputationRank | maxcount | stackable | ContainerSlots | StatsCount | stat_type1 | stat_value1 | stat_type2 | stat_value2 | stat_type3 | stat_value3 | stat_type4 | stat_value4 | stat_type5 | stat_value5 | stat_type6 | stat_value6 | stat_type7 | stat_value7 | stat_type8 | stat_value8 | stat_type9 | stat_value9 | stat_type10 | stat_value10 | ScalingStatDistribution | ScalingStatValue | dmg_min1 | dmg_max1 | dmg_type1 | dmg_min2 | dmg_max2 | dmg_type2 | armor | holy_res | fire_res | nature_res | frost_res | shadow_res | arcane_res | delay | ammo_type | RangedModRange | spellid_1 | spelltrigger_1 | spellcharges_1 | spellppmRate_1 | spellcooldown_1 | spellcategory_1 | spellcategorycooldown_1 | spellid_2 | spelltrigger_2 | spellcharges_2 | spellppmRate_2 | spellcooldown_2 | spellcategory_2 | spellcategorycooldown_2 | spellid_3 | spelltrigger_3 | spellcharges_3 | spellppmRate_3 | spellcooldown_3 | spellcategory_3 | spellcategorycooldown_3 | spellid_4 | spelltrigger_4 | spellcharges_4 | spellppmRate_4 | spellcooldown_4 | spellcategory_4 | spellcategorycooldown_4 | spellid_5 | spelltrigger_5 | spellcharges_5 | spellppmRate_5 | spellcooldown_5 | spellcategory_5 | spellcategorycooldown_5 | bonding | description | PageText | LanguageID | PageMaterial | startquest | lockid | Material | sheath | RandomProperty | RandomSuffix | block | itemset | MaxDurability | area | Map | BagFamily | TotemCategory | socketColor_1 | socketContent_1 | socketColor_2 | socketContent_2 | socketColor_3 | socketContent_3 | socketBonus | GemProperties | RequiredDisenchantSkill | ArmorDamageModifier | duration | ItemLimitCategory | HolidayId | ScriptName | DisenchantID | FoodType | minMoneyLoot | maxMoneyLoot | flagsCustom | VerifiedBuild |
+-------+-------+----------+-----------------------+--------------+-----------+---------+-------+------------+----------+----------+-----------+---------------+----------------+---------------+-----------+---------------+---------------+-------------------+---------------+-------------------+------------------+---------------------------+------------------------+----------+-----------+----------------+------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+------------+-------------+-------------+--------------+-------------------------+------------------+----------+----------+-----------+----------+----------+-----------+-------+----------+----------+------------+-----------+------------+------------+-------+-----------+----------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+-----------+----------------+----------------+----------------+-----------------+-----------------+-------------------------+---------+-------------+----------+------------+--------------+------------+--------+----------+--------+----------------+--------------+-------+---------+---------------+------+-----+-----------+---------------+---------------+-----------------+---------------+-----------------+---------------+-----------------+-------------+---------------+-------------------------+---------------------+----------+-------------------+-----------+------------+--------------+----------+--------------+--------------+-------------+---------------+
| 43127 |     7 |        1 |                    -1 | Snowfall Ink |     55112 |       2 |     0 |          0 |        1 |        0 |       500 |             0 |             -1 |            -1 |        70 |             0 |             0 |                 0 |             0 |                 0 |                0 |                         0 |                      0 |        0 |        20 |              0 |          0 |          0 |           0 |          0 |           0 |          0 |           0 |          0 |           0 |          0 |           0 |          0 |           0 |          0 |           0 |          0 |           0 |          0 |           0 |           0 |            0 |                       0 |                0 |        0 |        0 |         0 |        0 |        0 |         0 |     0 |        0 |        0 |          0 |         0 |          0 |          0 |     0 |         0 |              0 |         0 |              0 |              0 |              0 |              -1 |               0 |                      -1 |         0 |              0 |              0 |              0 |              -1 |               0 |                      -1 |         0 |              0 |              0 |              0 |              -1 |               0 |                      -1 |         0 |  0             |              0 |              0 |              -1 |               0 |                      -1 |         0 |              0 |              0 |              0 |              -1 |               0 |                      -1 |       0 |             |        0 |          0 |            0 |          0 |      0 |        3 |      0 |              0 |            0 |     0 |       0 |             0 |    0 |   0 |        16 |             0 |             0 |               0 |             0 |               0 |             0 |               0 |           0 |             0 |                      -1 |                   0 |        0 |                 0 |         0 |            |            0 |        0 |            0 |            0 |           0 |         12340 |

This means that during the items bins initialization the mod will not consider such items depending on the strategy selected, since it does not have a starting price to begin with.

I've recently pushed a PR solving this unhandled case, where the price is guessed using an heuristic that take into account the item level and the normal multiplication factors used by the normal selling process. This way you can have items with 0 price being sold for something and they will appear in the auction house.

My server already has the patch running and right now everything is fine and I can buy reagents to level up my enchanting, for example. You just have to wait for the maintainers to test and accept the changes. IF you want to can also go on and use the branch in my repo, test this and then report back your findings about that, especially if the price selected by the algorithm is fine enough.

[cesuogui]

@kewinrausch Thanks I will try it

[BusaSpectre]

Found at least part of the problem. Several trade goods are listed in "mod_auctionhousebot_disabled_items"

Items I've found so far (with item ID included):
Gold Bar ( 3577 )
Gold Ore ( 2776 )
most of the missing enchanting items (example: Lesser Astral Essence - item 10998 )
Portable Hole ( 51809 )

Removing these from that table allows them to show up in the auction house.
I've also added base prices of 3 silver to all items with a "0" buy/sell value prior to this, so YMMV.

Hopefully this helps others workaround the issue until a proper fix can be done, and hopefully this help the author identify the root cause.