multipart upload event lifecycles

add dev config

fix unseekable stream failure initial request

update try catch

fix null pointer

add comment

stack-info: PR: #4061, branch: GarrettBeatty/stacked/3

Author: GarrettBeatty

generator/.DevConfigs/433a9a6d-b8ea-4676-b763-70711e8288e3.json

@@ -0,0 +1,12 @@
+{
+  "services": [
+    {
+      "serviceName": "S3",
+      "type": "patch",
+      "changeLogMessages": [
+        "Added progress tracking events to multipart upload",
+        "Added CompleteMultipartUploadResponse to TransferUtilityUploadResponse mapping"
+      ]
+    }
+  ]
+}

sdk/src/Services/S3/Custom/Transfer/Internal/MultipartUploadCommand.cs

@@ -372,10 +372,46 @@ private void UploadPartProgressEventCallback(object sender, UploadProgressArgs e
             long transferredBytes = Interlocked.Add(ref _totalTransferredBytes, e.IncrementTransferred - e.CompensationForRetry);
 
             var progressArgs = new UploadProgressArgs(e.IncrementTransferred, transferredBytes, this._contentLength,
-                e.CompensationForRetry, this._fileTransporterRequest.FilePath);
+                e.CompensationForRetry, this._fileTransporterRequest.FilePath, this._fileTransporterRequest);
             this._fileTransporterRequest.OnRaiseProgressEvent(progressArgs);
         }
 
+        private void FireTransferInitiatedEvent()
+        {
+            var initiatedArgs = new UploadInitiatedEventArgs(
+                request: _fileTransporterRequest,
+                filePath: _fileTransporterRequest.FilePath,
+                totalBytes: _contentLength
+            );
+            
+            _fileTransporterRequest.OnRaiseTransferInitiatedEvent(initiatedArgs);
+        }
+
+        private void FireTransferCompletedEvent(TransferUtilityUploadResponse response)
+        {
+            var completedArgs = new UploadCompletedEventArgs(
+                request: _fileTransporterRequest,
+                response: response,
+                filePath: _fileTransporterRequest.FilePath,
+                transferredBytes: Interlocked.Read(ref _totalTransferredBytes),
+                totalBytes: _contentLength
+            );
+            
+            _fileTransporterRequest.OnRaiseTransferCompletedEvent(completedArgs);
+        }
+
+        private void FireTransferFailedEvent()
+        {
+            var failedArgs = new UploadFailedEventArgs(
+                request: _fileTransporterRequest,
+                filePath: _fileTransporterRequest.FilePath,
+                transferredBytes: Interlocked.Read(ref _totalTransferredBytes),
+                totalBytes: _contentLength
+            );
+            
+            _fileTransporterRequest.OnRaiseTransferFailedEvent(failedArgs);
+        }
+
         /// <summary>
         /// <para>
         /// If a checksum algorithm was not specified, we MUST add the default value used by the SDK (as the individual part 

sdk/src/Services/S3/Custom/Transfer/Internal/_async/MultipartUploadCommand.async.cs

@@ -33,21 +33,33 @@ internal partial class MultipartUploadCommand : BaseCommand
 
         public override async Task ExecuteAsync(CancellationToken cancellationToken)
         {
+            // Fire transfer initiated event FIRST, before choosing path
+            FireTransferInitiatedEvent();
+
             if ( (this._fileTransporterRequest.InputStream != null && !this._fileTransporterRequest.InputStream.CanSeek) || this._fileTransporterRequest.ContentLength == -1)
             {
                 await UploadUnseekableStreamAsync(this._fileTransporterRequest, cancellationToken).ConfigureAwait(false);
             }
             else
             {
-                var initRequest = ConstructInitiateMultipartUploadRequest();
-                var initResponse = await _s3Client.InitiateMultipartUploadAsync(initRequest, cancellationToken)
+                InitiateMultipartUploadResponse initResponse = null;
+                try
+                {
+                    var initRequest = ConstructInitiateMultipartUploadRequest();
+                    initResponse = await _s3Client.InitiateMultipartUploadAsync(initRequest, cancellationToken)
                     .ConfigureAwait(continueOnCapturedContext: false);
-                Logger.DebugFormat("Initiated upload: {0}", initResponse.UploadId);
+                    Logger.DebugFormat("Initiated upload: {0}", initResponse.UploadId);
+                }
+                catch (Exception)
+                {
+                    FireTransferFailedEvent();
+                    throw;
+                }
 
                 var pendingUploadPartTasks = new List<Task<UploadPartResponse>>();
-
                 SemaphoreSlim localThrottler = null;
                 CancellationTokenSource internalCts = null;
+                
                 try
                 {
                     Logger.DebugFormat("Queue up the UploadPartRequests to be executed");
@@ -101,14 +113,19 @@ await localThrottler.WaitAsync(cancellationToken)
 
                     Logger.DebugFormat("Beginning completing multipart. ({0})", initResponse.UploadId);
                     var compRequest = ConstructCompleteMultipartUploadRequest(initResponse);
-                    await this._s3Client.CompleteMultipartUploadAsync(compRequest, cancellationToken)
+                    var completeResponse = await this._s3Client.CompleteMultipartUploadAsync(compRequest, cancellationToken)
                         .ConfigureAwait(continueOnCapturedContext: false);
                     Logger.DebugFormat("Done completing multipart. ({0})", initResponse.UploadId);
 
+                    var mappedResponse = ResponseMapper.MapCompleteMultipartUploadResponse(completeResponse);
+                    FireTransferCompletedEvent(mappedResponse);
                 }
                 catch (Exception e)
                 {
-                    Logger.Error(e, "Exception while uploading. ({0})", initResponse.UploadId);
+                    Logger.Error(e, "Exception while uploading. ({0})", initResponse?.UploadId ?? "unknown");
+
+                    FireTransferFailedEvent();
+                    
                     // Can't do async invocation in the catch block, doing cleanup synchronously.
                     Cleanup(initResponse.UploadId, pendingUploadPartTasks);
                     throw;
@@ -201,8 +218,19 @@ private void AbortMultipartUpload(string uploadId)
                 }
             };
 
-            var initiateRequest = ConstructInitiateMultipartUploadRequest(requestEventHandler);
-            var initiateResponse = await _s3Client.InitiateMultipartUploadAsync(initiateRequest, cancellationToken).ConfigureAwait(false);
+            InitiateMultipartUploadResponse initiateResponse = null;
+            
+            try
+            {
+                var initiateRequest = ConstructInitiateMultipartUploadRequest(requestEventHandler);
+                initiateResponse = await _s3Client.InitiateMultipartUploadAsync(initiateRequest, cancellationToken).ConfigureAwait(false);
+            }
+            catch (Exception ex)
+            {
+                FireTransferFailedEvent();
+                Logger.Error(ex, "Failed to initiate multipart upload for unseekable stream");
+                throw;
+            }
 
             try
             {
@@ -270,12 +298,17 @@ private void AbortMultipartUpload(string uploadId)
 
                     this._uploadResponses = uploadPartResponses;
                     CompleteMultipartUploadRequest compRequest = ConstructCompleteMultipartUploadRequest(initiateResponse, true, requestEventHandler);
-                    await _s3Client.CompleteMultipartUploadAsync(compRequest, cancellationToken).ConfigureAwait(false);
+                    var completeResponse = await _s3Client.CompleteMultipartUploadAsync(compRequest, cancellationToken).ConfigureAwait(false);
                     Logger.DebugFormat("Completed multi part upload. (Part count: {0}, Upload Id: {1})", uploadPartResponses.Count, initiateResponse.UploadId);
+
+                    var mappedResponse = ResponseMapper.MapCompleteMultipartUploadResponse(completeResponse);
+                    FireTransferCompletedEvent(mappedResponse);
                 }
             }
             catch (Exception ex)
             {
+                FireTransferFailedEvent();
+
                 await _s3Client.AbortMultipartUploadAsync(new AbortMultipartUploadRequest()
                 {
                     BucketName = request.BucketName,