Allow errors as event stream output members #6592
Open
+32
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Motivation and Context
Smithy spec states:
https://smithy.io/2.0/spec/streaming.html#modeled-errors-in-event-streams
Codegen currently throws a NPE if a exception shape is a member of an event stream output. This is because the Java SDK codegen stores exception shape names by appending a suffix
Exception.Modifications
Update
RemoveUnusedShapes.resolveMemberShapes(), so that if the shape type isException, and theMemberModelC2J shape name equals theShapeModelC2J name, to resolve the shape name (original name) instead of returning the simple type (withExceptionsuffix)Testing
Added exception shape to event stream output in codegen test model
Screenshots (if appropriate)
Types of changes