This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Change e2e tooling to accomodate mulitple network types #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
requested review from
geoff-vball,
iansuvak,
mdelle1,
michaelkaplan13 and
ylg-avalabs
batconjurer
changed the base branch from
main
to
bat/add-warp-interface-to-teleporter
batconjurer
force-pushed
the
bat/allow-mutliple-test-networks
branch
from
9422351 to
c8c8cf9
Compare
iansuvak
approved these changes
Dec 1, 2025
Contributor
iansuvak
left a comment
iansuvak
left a comment
There was a problem hiding this comment.
LGTM but let's recreate in icm-services post repo merge.
I like the change of using clients directly instead of the L1TestInfo
geoff-vball
reviewed
Dec 1, 2025
Contributor
geoff-vball
left a comment
geoff-vball
left a comment
There was a problem hiding this comment.
Looks good. I'd echo @iansuvak here and let's add this in after the graft is complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This changes the e2e tooling slightly so that we can have both avalanche and ethereum networks in our e2e tests. The mainly changes the name
LocalNetwork->LocalAvalancheNetworkand allows making RPC calls with eth clients directly rather than L1Info. It produces a large enough diff that I decided to break it out into a separate PR. Builds on top of PR #891How this works
How this was tested
How is this documented