Skip to content

Conversation

@RodrigoVillar
Copy link
Contributor

Why this should be merged

#4443 introduced a bug where running task reexecute-cchain-range would fail if EXECUTION_DATA_DIR was not set by the client. Clients would get the following error log:

task: [reexecute-cchain-range] CURRENT_STATE_DIR=/Users/rodrigo.villar/exec-data/current-state \
BLOCK_DIR=/Users/rodrigo.villar/exec-data/blocks \
CONFIG= \
START_BLOCK=1 \
END_BLOCK=10_000 \
LABELS= \
BENCHMARK_OUTPUT_FILE= \
EXECUTION_DATA_DIR=/tmp/%!s(<nil>)-20251202-090826 \
bash -x ./scripts/benchmark_cchain_range.sh

task: Failed to run task "reexecute-cchain-range": 8:28: a command can only contain words and redirects; encountered (

The source of this bug seems to be the usage of .TASK_NAME, which doesn't exist. Using .TASK however seems to work.

How this works

Switches from using .TASK_NAME to .TASK

How this was tested

Ran task reexecute-cchain-range START_BLOCK=1 END_BLOCK=50_000 with CURRENT_STATE_DIR and BLOCK_DIR set as environment variables.

Need to be documented in RELEASES.md?

No

@RodrigoVillar RodrigoVillar self-assigned this Dec 2, 2025
Copilot AI review requested due to automatic review settings December 2, 2025 14:18
@RodrigoVillar RodrigoVillar added the bug Something isn't working label Dec 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the reexecute-cchain-range task where using an incorrect template variable (.TASK_NAME) caused task execution to fail when EXECUTION_DATA_DIR was not explicitly set by the user.

  • Corrected template variable from .TASK_NAME to .TASK for generating default execution data directory path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aaronbuchwald aaronbuchwald added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@aaronbuchwald aaronbuchwald added this pull request to the merge queue Dec 3, 2025
Merged via the queue into master with commit c031927 Dec 3, 2025
40 checks passed
@aaronbuchwald aaronbuchwald deleted the rodrigo/fix-execution-data-dir branch December 3, 2025 20:48
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working reexecution

Projects

Status: Done 🎉

Development

Successfully merging this pull request may close these issues.

5 participants