forked from confluentinc/parallel-consumer
-
Notifications
You must be signed in to change notification settings - Fork 8
confluentinc#259: Consider adopting error prone and checker #144
Copy link
Copy link
Open
Labels
0.6.0.0Targeted at the 0.6.0.0 releaseTargeted at the 0.6.0.0 releasearea/build-testArea: build-testArea: build-testchoreMaintenance work, no user-visible behaviour changeMaintenance work, no user-visible behaviour changeupstream-mirrorMirrored from the upstream confluentinc trackerMirrored from the upstream confluentinc tracker
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
0.6.0.0Targeted at the 0.6.0.0 releaseTargeted at the 0.6.0.0 releasearea/build-testArea: build-testArea: build-testchoreMaintenance work, no user-visible behaviour changeMaintenance work, no user-visible behaviour changeupstream-mirrorMirrored from the upstream confluentinc trackerMirrored from the upstream confluentinc tracker
Summary
Suggests adopting Error Prone and the Checker Framework alongside SpotBugs.
Fork status
One of the three is adopted; the other two are not.
SpotBugs is in:
pom.xml:877-893configures spotbugs-maven-plugin at<effort>Max</effort>/<threshold>Medium</threshold>, andmaven.yml:245-305runs it as astatic: spotbugsjob with acached baseline, so only newly introduced findings fail a PR. That arrived with the fork's CI
modernisation and ships in 0.6.0.0.
Error Prone and the Checker Framework are absent - searched pom.xml, every module and
.github/for
errorprone|error_prone|checkerframework|checker-qual|nullaway; the only hit is the phrase"error-prone" in prose in AGENTS.md.
The obstacle worth knowing before trying: the build compiles at
source.version 17butrelease.target 8via Jabel. Error Prone hooks into javac and the Checker Framework runs as anannotation processor, so both need care against that setup - this is not a "add a plugin" job.