-
-
Notifications
You must be signed in to change notification settings - Fork 280
Open
Description
Describe the bug
When the player reaches the end of recording in paused state (through seek
or fast-forwarding the playback with keyboard shortcuts), and then tries to play again, the controls stop working, and an uncaught error is thrown.
To Reproduce
Steps to reproduce the behavior:
- Start playing normally
- Pause the playback
- Press right arrow
→
until reaching the end, still on pause - After ending, press the play button or
space
Controls stop working (except fullscreen and keyboard shortcuts buttons/shortcuts), and an uncaught error is thrown in the console.
Expected behavior
The recording replay normally, just like when the end of the recording is reached in playing state.
Versions:
- OS: Pop!_OS 22.04 LTS 64-bit
- Browsers: Brave 1.76.82 - Chromium 134.0.6998.178 | Firefox 137
- asciinema player: 3.9.0
Additional context
Error (tried to replay using space
shortcut):
Uncaught (in promise) already ended
| Promise.then
| _enqueueCommand @ asciinema-player.js?v=d4cfb7fc:2569
| _withState @ asciinema-player.js?v=d4cfb7fc:2566
| togglePlay @ asciinema-player.js?v=d4cfb7fc:2503
| onKeyDown @ asciinema-player.js?v=d4cfb7fc:4676
| eventHandler @ asciinema-player.js?v=d4cfb7fc:3560
That's the PR making the player implementation in Shellhub, and the source of the issue.
gustavosbarreto
Metadata
Metadata
Assignees
Labels
No labels