Skip to content

Commit 0b2430b

Browse files
committed
Keep the Windows E2E jobs sequential
Running the Windows suite in parallel cut it from ~21 min to ~5.5 min, but a `--parallel 1` control run on main was green while every parallel run failed on a different test — six distinct tests across three runs, never the same one twice. Parallelism exposes latent timing races rather than breaking anything deterministically, and lowering Bun to 2 did not help either. Revert the workflow to sequential and keep only the changes that are independent of parallelism. Enabling it needs those races fixed first; one root cause is the hardcoded 5s IPC-credential timeout in the bridge, recorded in #353. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HUzrgoGWLirnc3zyeVZLz5
1 parent 9598566 commit 0b2430b

1 file changed

Lines changed: 2 additions & 16 deletions

File tree

.github/workflows/e2e-windows.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,7 @@ jobs:
3030
run: pnpm run build
3131

3232
- name: E2E tests
33-
# windows-latest runners have 4 vCPUs, so run 4 tests at a time (same as
34-
# macOS). Process spawning is far more expensive on Windows than on Linux
35-
# and the suite is spawn-bound, so it was previously run sequentially and
36-
# took ~21 min — by far the slowest job in CI.
37-
env:
38-
# Individual tests slow down under parallel contention; the watchdog only
39-
# needs to catch genuine hangs, so give it headroom over the 180s default.
40-
E2E_PER_TEST_TIMEOUT: 300
41-
run: ./test/e2e/run.sh --no-build --parallel 4
33+
run: ./test/e2e/run.sh --no-build --parallel 1
4234

4335
e2e-windows-bun:
4436
name: E2E tests (Windows, Bun)
@@ -66,10 +58,4 @@ jobs:
6658
run: pnpm run build
6759

6860
- name: E2E tests
69-
# Bun on Windows is less tolerant of contention than Node: at --parallel 4
70-
# it intermittently failed with bridge startup errors on tests that passed
71-
# in other runs, so this job uses 2. Still roughly half the previous
72-
# sequential runtime. See the note in e2e-windows-node above.
73-
env:
74-
E2E_PER_TEST_TIMEOUT: 300
75-
run: ./test/e2e/run.sh --no-build --runtime bun --parallel 2
61+
run: ./test/e2e/run.sh --no-build --runtime bun --parallel 1

0 commit comments

Comments
 (0)