Clone parameter to prevent duplicate instance in tree (#228)

Clone parameter to prevent duplicate instance in tree

Author: kylef

packages/fury-adapter-oas3-parser/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Fury OAS3 Parser Changelog
 
+## Master
+
+### Bug Fixes
+
+- Prevents an exception being raised when using `freeze()` on the parse result
+  returned by the parser when you reference a parameter component multiple
+  times in an OpenAPI Document.
+
 ## 0.7.4 (2019-04-12)
 
 ### Enhancements

packages/fury-adapter-oas3-parser/lib/parser/oas/parseOperationObject.js

@@ -156,7 +156,7 @@ function parseOperationObject(context, path, member) {
               R.reject(member => !headers.include(member.key.toValue()).isEmpty, headerParameters.content)
             );
 
-            request.headers = headers;
+            request.headers = headers.clone();
           });
         }
       }

packages/fury-adapter-oas3-parser/lib/parser/oas/parseParameterObjects.js

@@ -29,9 +29,9 @@ function parseParameterObjects(context, name, array) {
 
   // Convert an array of parameters into the correct types
   const convertParameters = R.cond([
-    [isPathOrQuery, member => new namespace.elements.HrefVariables(member.value.content)],
+    [isPathOrQuery, member => new namespace.elements.HrefVariables(member.value.clone().content)],
     // FIXME when headers and cookies are supported these should be converted
-    [R.T, member => member],
+    [R.T, member => member.clone()],
   ]);
 
   const parseParameters = pipeParseResult(namespace,

packages/fury-adapter-oas3-parser/test/integration/components-test.js

@@ -4,44 +4,72 @@ const testParseFixture = require('./testParseFixture');
 const fixtures = path.join(__dirname, 'fixtures', 'components');
 
 describe('components', () => {
-  it("'Path Item Object' parameter references", () => {
-    const file = path.join(fixtures, 'path-item-object-parameters');
-    return testParseFixture(file);
-  });
+  describe('Path Item Object', () => {
+    it('handles parameter references', () => {
+      const file = path.join(fixtures, 'path-item-object-parameters');
+      return testParseFixture(file);
+    });
 
-  it("'Path Item Object' parameter referencing unsupported parameter", () => {
-    const file = path.join(fixtures, 'path-item-object-parameters-unsupported-parameter');
-    return testParseFixture(file);
-  });
+    it('handles multiple references to same parameter', () => {
+      const file = path.join(fixtures, 'path-item-object-parameters-multiple');
+      return testParseFixture(file);
+    });
 
-  it("'Media Type Object' schema references", () => {
-    const file = path.join(fixtures, 'media-type-object-schema');
-    return testParseFixture(file);
+    it('handles parameter referencing unsupported parameter', () => {
+      const file = path.join(fixtures, 'path-item-object-parameters-unsupported-parameter');
+      return testParseFixture(file);
+    });
   });
 
-  it("'Media Type Object' examples references", () => {
-    const file = path.join(fixtures, 'media-type-object-examples');
-    return testParseFixture(file);
-  });
+  describe('Media Type Object', () => {
+    it('handles schema references', () => {
+      const file = path.join(fixtures, 'media-type-object-schema');
+      return testParseFixture(file);
+    });
 
-  it("'Responses Object' response references", () => {
-    const file = path.join(fixtures, 'responses-object-response');
-    return testParseFixture(file);
-  });
+    it('handles multiple references to same schema', () => {
+      const file = path.join(fixtures, 'media-type-object-schema-multiple');
+      return testParseFixture(file);
+    });
 
-  it("'Responses Object' response references with schema", () => {
-    const file = path.join(fixtures, 'responses-object-response-with-schema');
-    return testParseFixture(file);
+    it('handles examples references', () => {
+      const file = path.join(fixtures, 'media-type-object-examples');
+      return testParseFixture(file);
+    });
   });
 
-  it("'Responses Object' respomnse references with headers", () => {
-    const file = path.join(fixtures, 'responses-object-response-with-headers');
-    return testParseFixture(file);
+  describe('Responses Object', () => {
+    it('handles response references', () => {
+      const file = path.join(fixtures, 'responses-object-response');
+      return testParseFixture(file);
+    });
+
+    it('handles multiple references to same response', () => {
+      const file = path.join(fixtures, 'responses-object-response-multiple');
+      return testParseFixture(file);
+    });
+
+    it('handles response references with schema', () => {
+      const file = path.join(fixtures, 'responses-object-response-with-schema');
+      return testParseFixture(file);
+    });
+
+    it('handles responses references with headers', () => {
+      const file = path.join(fixtures, 'responses-object-response-with-headers');
+      return testParseFixture(file);
+    });
   });
 
-  it("'Response Object' headers references", () => {
-    const file = path.join(fixtures, 'response-object-headers');
-    return testParseFixture(file);
+  describe('Response Object', () => {
+    it('handles headers references', () => {
+      const file = path.join(fixtures, 'response-object-headers');
+      return testParseFixture(file);
+    });
+
+    it('handles multiple references to same header', () => {
+      const file = path.join(fixtures, 'response-object-headers-multiple');
+      return testParseFixture(file);
+    });
   });
 
   it("'Schema Object' circular references", () => {