SLING-10136 Add operation for deleting a path #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@bdelacretaz Any thoughts? |
Member
|
Sorry that I took so long to take a look at this. The code looks good to me. In SLING-10136, Konrad expresses concerns about implementing this operation, I think those should be addressed before merging this. |
Author
I agree! How can we address this issue though? I'm fine with any concensus we can reach. |
Member
I think best is to discuss it in SLING-10136, I added some comments there. I might not be available in the next few days to discuss more, don't wait for me if you reach consensus there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.