Skip to content

Commit 86632c9

Browse files
authored
change TestThreadPoolPublishModelFactory to deterministic implementation (#4969)
1 parent 2d8bfe6 commit 86632c9

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/publish/TestThreadPoolPublishModelFactory.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
2525
import org.apache.servicecomb.metrics.core.ThreadPoolMetersInitializer;
2626
import org.apache.servicecomb.metrics.core.publish.model.DefaultPublishModel;
27-
import org.junit.jupiter.api.Assertions;
2827
import org.junit.jupiter.api.MethodOrderer;
2928
import org.junit.jupiter.api.Test;
3029
import org.junit.jupiter.api.TestMethodOrder;
@@ -36,6 +35,8 @@
3635
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
3736
import org.mockito.junit.jupiter.MockitoExtension;
3837

38+
import org.skyscreamer.jsonassert.JSONAssert;
39+
3940
@ExtendWith(MockitoExtension.class)
4041
@TestMethodOrder(MethodOrderer.MethodName.class)
4142
public class TestThreadPoolPublishModelFactory {
@@ -61,9 +62,9 @@ public void createThreadPoolMeters() {
6162
PublishModelFactory factory = new PublishModelFactory(registry.getMeters());
6263
DefaultPublishModel model = factory.createDefaultPublishModel();
6364

64-
Assertions.assertEquals(
65+
JSONAssert.assertEquals(
6566
"""
6667
{"test":{"avgTaskCount":0.0,"avgCompletedTaskCount":0.0,"currentThreadsBusy":0,"maxThreads":0,"poolSize":0,"corePoolSize":0,"queueSize":10,"rejected":0.0}}""",
67-
JsonUtils.writeValueAsString(model.getThreadPools()));
68+
JsonUtils.writeValueAsString(model.getThreadPools()), false);
6869
}
6970
}

0 commit comments

Comments
 (0)