-
Notifications
You must be signed in to change notification settings - Fork 461
add changes to release resources when the channel becomes inactive #2241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
add changes to release resources when the channel becomes inactive #2241
Conversation
|
Hi Frank, Chris |
|
Could you please increase the log level for your additional log output to something "debug" or "trace"? "info" makes the drivers quite noisy. |
|
|
||
| @Override | ||
| public void channelInactive(ChannelHandlerContext ctx) throws Exception { | ||
| logger.info("channelInactive.. context: {}", ctx.name()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this to "debug" or "trace"
|
|
||
| @Override | ||
| public void channelInactive(ConversationContext<Message> context) { | ||
| logger.info("On ChannelInactive"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set this to "debug" or "trace"
Hello Chris, |
While I was looking into this issue I found out that there are two leaks. The first is related to the RequestTransactionManager and the other is from the NettyHashTimerTimeoutManager. As I was mentioning in the issue I opened last week, this leaks happens when the PLC goes offline and back online and the client tries to reconnecting to it in a cycle.
I was only able to test this on the modbus simulator which seems to work ok with the changes I made on this branch.
Please provide me a feedback or any consideration. I am attaching also a small video which shows that the resources are freed as expected.
Issue link
Screencast.2025-09-03.09.58.05.mp4