From a6222b0a3afb9acbecfb9a8a98aa1decb366afdc Mon Sep 17 00:00:00 2001
From: Aaron Niskode-Dossett <aniskodedossett@etsy.com>
Date: Mon, 22 Sep 2025 11:48:22 -0400
Subject: [PATCH 1/3] Remove unused parquet-thrift dependencies

---
 parquet-thrift/pom.xml | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/parquet-thrift/pom.xml b/parquet-thrift/pom.xml
index 15a31b43c4..8b78fd3971 100644
--- a/parquet-thrift/pom.xml
+++ b/parquet-thrift/pom.xml
@@ -107,12 +107,6 @@
       <artifactId>jackson-annotations</artifactId>
       <version>${jackson.version}</version>
     </dependency>
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-      <version>${guava.version}</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.parquet</groupId>
       <artifactId>parquet-column</artifactId>
@@ -132,17 +126,6 @@
       <classifier>${pig.classifier}</classifier>
       <scope>provided</scope>
     </dependency>
-    <dependency>
-      <groupId>javax.annotation</groupId>
-      <artifactId>javax.annotation-api</artifactId>
-      <version>${javax.annotation.version}</version>
-    </dependency>
-    <dependency> <!-- for pig runtime in tests -->
-      <groupId>org.antlr</groupId>
-      <artifactId>antlr-runtime</artifactId>
-      <version>3.5.3</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.thrift</groupId>
       <artifactId>libthrift</artifactId>
@@ -160,13 +143,6 @@
       <version>${slf4j.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <!-- needed for Pig tests -->
-      <groupId>log4j</groupId>
-      <artifactId>log4j</artifactId>
-      <version>1.2.17</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.parquet</groupId>
       <artifactId>parquet-hadoop</artifactId>

From 79a7425a6487b54d49ed3f22d99c3bf54ed2d9a2 Mon Sep 17 00:00:00 2001
From: Aaron Niskode-Dossett <aniskodedossett@etsy.com>
Date: Mon, 22 Sep 2025 13:44:44 -0400
Subject: [PATCH 2/3] Add back an implicit dependency; add comments

---
 parquet-thrift/pom.xml | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/parquet-thrift/pom.xml b/parquet-thrift/pom.xml
index 8b78fd3971..cc7da5184c 100644
--- a/parquet-thrift/pom.xml
+++ b/parquet-thrift/pom.xml
@@ -52,6 +52,8 @@
       <artifactId>parquet-common</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <!-- Several of these hadoop dependencies will show up as "unused" in dependnency analysis
+         but they are needed at runtime for several tests -->
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-client</artifactId>
@@ -65,7 +67,15 @@
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
-      <scope>provided</scope>
+      <scope>test</scope>
+    </dependency>
+    <!-- Guava is a dependency of hadoop-common, but scoped to compile. We need to
+         explicity declare it as a test dependency. -->
+    <dependency>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>${guava.version}</version>
+      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>com.twitter.elephantbird</groupId>
@@ -137,12 +147,6 @@
       <artifactId>slf4j-api</artifactId>
       <version>${slf4j.version}</version>
     </dependency>
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-simple</artifactId>
-      <version>${slf4j.version}</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.parquet</groupId>
       <artifactId>parquet-hadoop</artifactId>

From 77bed42c92eba8b1ac826380a3fc68a07d527126 Mon Sep 17 00:00:00 2001
From: Aaron Niskode-Dossett <aniskodedossett@etsy.com>
Date: Mon, 22 Sep 2025 16:03:18 -0400
Subject: [PATCH 3/3] fix scope

---
 parquet-thrift/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parquet-thrift/pom.xml b/parquet-thrift/pom.xml
index cc7da5184c..ade1ec3cdc 100644
--- a/parquet-thrift/pom.xml
+++ b/parquet-thrift/pom.xml
@@ -67,7 +67,7 @@
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
-      <scope>test</scope>
+      <scope>provided</scope>
     </dependency>
     <!-- Guava is a dependency of hadoop-common, but scoped to compile. We need to
          explicity declare it as a test dependency. -->