Skip to content

Commit 79a7425

Browse files
committed
Add back an implicit dependency; add comments
1 parent a6222b0 commit 79a7425

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

parquet-thrift/pom.xml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252
<artifactId>parquet-common</artifactId>
5353
<version>${project.version}</version>
5454
</dependency>
55+
<!-- Several of these hadoop dependencies will show up as "unused" in dependnency analysis
56+
but they are needed at runtime for several tests -->
5557
<dependency>
5658
<groupId>org.apache.hadoop</groupId>
5759
<artifactId>hadoop-client</artifactId>
@@ -65,7 +67,15 @@
6567
<dependency>
6668
<groupId>org.apache.hadoop</groupId>
6769
<artifactId>hadoop-common</artifactId>
68-
<scope>provided</scope>
70+
<scope>test</scope>
71+
</dependency>
72+
<!-- Guava is a dependency of hadoop-common, but scoped to compile. We need to
73+
explicity declare it as a test dependency. -->
74+
<dependency>
75+
<groupId>com.google.guava</groupId>
76+
<artifactId>guava</artifactId>
77+
<version>${guava.version}</version>
78+
<scope>test</scope>
6979
</dependency>
7080
<dependency>
7181
<groupId>com.twitter.elephantbird</groupId>
@@ -137,12 +147,6 @@
137147
<artifactId>slf4j-api</artifactId>
138148
<version>${slf4j.version}</version>
139149
</dependency>
140-
<dependency>
141-
<groupId>org.slf4j</groupId>
142-
<artifactId>slf4j-simple</artifactId>
143-
<version>${slf4j.version}</version>
144-
<scope>test</scope>
145-
</dependency>
146150
<dependency>
147151
<groupId>org.apache.parquet</groupId>
148152
<artifactId>parquet-hadoop</artifactId>

0 commit comments

Comments
 (0)