Skip to content

KAFKA-15700: FetchFromFollowerIntegrationTest is flaky #20982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-15700: FetchFromFollowerIntegrationTest is flaky #20982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bae0f5
Add commit sync after each verification
jack2012aa Nov 24, 2025
fabfa62
Simplify
jack2012aa Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ import org.apache.kafka.common.serialization.ByteArrayDeserializer
import org.apache.kafka.coordinator.group.GroupCoordinatorConfig
import org.apache.kafka.server.config.ServerLogConfigs
import org.junit.jupiter.api.Assertions.{assertEquals, assertTrue}
import org.junit.jupiter.api.{Disabled, Timeout}
import org.junit.jupiter.api.Timeout
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.MethodSource
import org.junit.jupiter.params.provider.{MethodSource, ValueSource}

import java.util
import java.util.Properties
Expand Down Expand Up @@ -181,9 +181,8 @@ class FetchFromFollowerIntegrationTest extends BaseFetchRequestTest {
}
}

@Disabled
@ParameterizedTest(name = TestInfoUtils.TestWithParameterizedGroupProtocolNames)
@MethodSource(Array("getTestGroupProtocolParametersAll"))
@ValueSource(strings = Array("classic"))
Copy link
Member

@lianetm lianetm Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, this test is for the client-side RangeAssignor so it does not apply to the consumer protocol

def testRackAwareRangeAssignor(groupProtocol: String): Unit = {
val partitionList = brokers.indices.toList

Expand Down Expand Up @@ -235,6 +234,7 @@ class FetchFromFollowerIntegrationTest extends BaseFetchRequestTest {
val records = future.get(30, TimeUnit.SECONDS)
assertEquals(assignments(i), records.map(r => new TopicPartition(r.topic, r.partition)).toSet)
}
consumers.foreach{ _.commitSync() }
Copy link
Member

@lianetm lianetm Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we disable auto-commits now that we're using manual?

}


Expand Down