From 83e414fb1198c36b5e5904b95dc95a3e65ea48e6 Mon Sep 17 00:00:00 2001 From: Jhen-Yung Hsu Date: Wed, 8 Oct 2025 17:42:56 +0800 Subject: [PATCH 1/5] MINOR: ignore missing build scan result --- .github/workflows/ci-complete.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-complete.yml b/.github/workflows/ci-complete.yml index 1dbd0871e9d1d..005c048b79315 100644 --- a/.github/workflows/ci-complete.yml +++ b/.github/workflows/ci-complete.yml @@ -89,7 +89,7 @@ jobs: url: '${{ github.event.workflow_run.html_url }}' description: 'Could not find build scan' context: Gradle Build Scan / ${{ env.status-context }} - state: 'error' + state: 'success' # WAR: Always mark as successful, not show as failing, for those branches without the KAFKA-18748 patches. - name: Publish Scan id: publish-build-scan if: ${{ steps.download-build-scan.outcome == 'success' }} From b76cdf622e45a007f20adcfd1d05ecc9a006c505 Mon Sep 17 00:00:00 2001 From: Jhen-Yung Hsu Date: Wed, 8 Oct 2025 18:27:48 +0800 Subject: [PATCH 2/5] Revert previous failed approach --- .github/workflows/ci-complete.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-complete.yml b/.github/workflows/ci-complete.yml index 005c048b79315..b93de3196ceb4 100644 --- a/.github/workflows/ci-complete.yml +++ b/.github/workflows/ci-complete.yml @@ -38,7 +38,7 @@ run-name: Build Scans for ${{ github.event.workflow_run.display_title}} jobs: upload-build-scan: # Skip this workflow if the CI run was skipped or cancelled - if: (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure') && github.event.workflow_run.head_branch != '4.0' + if: (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure') runs-on: ubuntu-latest strategy: fail-fast: false From 1240815e3388eee2e6eb53465bdbbd2474a98d95 Mon Sep 17 00:00:00 2001 From: Jhen-Yung Hsu Date: Wed, 8 Oct 2025 18:31:25 +0800 Subject: [PATCH 3/5] Improve code comment --- .github/workflows/ci-complete.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-complete.yml b/.github/workflows/ci-complete.yml index b93de3196ceb4..6b4f1af6e0913 100644 --- a/.github/workflows/ci-complete.yml +++ b/.github/workflows/ci-complete.yml @@ -89,7 +89,7 @@ jobs: url: '${{ github.event.workflow_run.html_url }}' description: 'Could not find build scan' context: Gradle Build Scan / ${{ env.status-context }} - state: 'success' # WAR: Always mark as successful, not show as failing, for those branches without the KAFKA-18748 patches. + state: 'success' # WAR: Mark as successful, not show as failing, for those branches without the KAFKA-18748 patches - name: Publish Scan id: publish-build-scan if: ${{ steps.download-build-scan.outcome == 'success' }} From 1e968c233365811197a4440529571663e30703bf Mon Sep 17 00:00:00 2001 From: Jhen-Yung Hsu Date: Wed, 8 Oct 2025 19:29:09 +0800 Subject: [PATCH 4/5] Improve code comment mentioned by chia --- .github/workflows/ci-complete.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-complete.yml b/.github/workflows/ci-complete.yml index 6b4f1af6e0913..d8f749ab40011 100644 --- a/.github/workflows/ci-complete.yml +++ b/.github/workflows/ci-complete.yml @@ -89,7 +89,7 @@ jobs: url: '${{ github.event.workflow_run.html_url }}' description: 'Could not find build scan' context: Gradle Build Scan / ${{ env.status-context }} - state: 'success' # WAR: Mark as successful, not show as failing, for those branches without the KAFKA-18748 patches + state: 'success' # WAR: Always mark as successful, not as failing, for non-trunk branches; real solution to follow in KAFKA-19768 - name: Publish Scan id: publish-build-scan if: ${{ steps.download-build-scan.outcome == 'success' }} From b6a8eb893ed2d36590d01bb8e6d6dc12fcb4d3b8 Mon Sep 17 00:00:00 2001 From: Jhen-Yung Hsu Date: Thu, 16 Oct 2025 00:01:04 +0800 Subject: [PATCH 5/5] Address DA's comment --- .github/workflows/ci-complete.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-complete.yml b/.github/workflows/ci-complete.yml index d8f749ab40011..3c6d905102974 100644 --- a/.github/workflows/ci-complete.yml +++ b/.github/workflows/ci-complete.yml @@ -89,7 +89,7 @@ jobs: url: '${{ github.event.workflow_run.html_url }}' description: 'Could not find build scan' context: Gradle Build Scan / ${{ env.status-context }} - state: 'success' # WAR: Always mark as successful, not as failing, for non-trunk branches; real solution to follow in KAFKA-19768 + state: 'success' # Always mark as successful as a temporary fix; non-trunk branches will miss build scan. Real fix in KAFKA-19768 - name: Publish Scan id: publish-build-scan if: ${{ steps.download-build-scan.outcome == 'success' }}