Skip to content

Commit 2a0101a

Browse files
MINOR: Tidy up comments in MetadataVersion (#20697)
The PR just tidies up the comments in the MetadataVersion class to do with using placeholder metadata versions for a future release as a way to use features to enable share groups and streams groups as previews in AK 4.1. The metadata versions are simply unstable 4.2 MVs now, which is entirely usual at this stage of the release. Reviewers: Chia-Ping Tsai <[email protected]>
1 parent c58cf1d commit 2a0101a

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ public enum MetadataVersion {
9696
// Bootstrap metadata version for version 1 of the GroupVersion feature (KIP-848).
9797
IBP_4_0_IV0(22, "4.0", "IV0", false),
9898

99-
// Add ELR related metadata records (KIP-966). Note, ELR is for preview only in 4.0.
99+
// Add ELR related metadata records (KIP-966).
100+
// Note, ELR was for preview only in 4.0 which required enabling explicitly.
100101
// PartitionRecord and PartitionChangeRecord are updated.
101102
// ClearElrRecord is added.
102103
IBP_4_0_IV1(23, "4.0", "IV1", true),
@@ -108,37 +109,22 @@ public enum MetadataVersion {
108109
IBP_4_0_IV3(25, "4.0", "IV3", false),
109110

110111
// Enables ELR by default for new clusters (KIP-966).
111-
// Share groups are preview in 4.1 (KIP-932).
112-
// Streams groups are early access in 4.1 (KIP-1071).
113112
IBP_4_1_IV0(26, "4.1", "IV0", false),
114113

115114
// Send FETCH version 18 in the replica fetcher (KIP-1166)
116115
IBP_4_1_IV1(27, "4.1", "IV1", false),
117116

118117
//
119118
// NOTE: MetadataVersions after this point are unstable and may be changed.
120-
// If users attempt to use an unstable MetadataVersion, they will get an error.
119+
// If users attempt to use an unstable MetadataVersion, they will get an error unless
120+
// they have set the configuration unstable.feature.versions.enable=true.
121121
// Please move this comment when updating the LATEST_PRODUCTION constant.
122122
//
123123

124-
// Insert any additional IBP_4_1_IVx versions above this comment, and bump the feature level of
125-
// IBP_4_2_IVx accordingly. When 4.2 development begins, IBP_4_2_IV0 will cease to be
126-
// a placeholder.
127-
128124
// Enables share groups by default for new clusters (KIP-932).
129-
//
130-
// *** THIS IS A PLACEHOLDER UNSTABLE VERSION WHICH IS USED TO DEFINE THE POINT AT WHICH ***
131-
// *** SHARE GROUPS BECOME PRODUCTION-READY IN THE FUTURE. ITS DEFINITION ALLOWS A SHARE ***
132-
// *** GROUPS FEATURE TO BE DEFINED IN 4.1 BUT TURNED OFF BY DEFAULT, ABLE TO BE TURNED ON ***
133-
// *** DYNAMICALLY TO TRY OUT THE PREVIEW CAPABILITY. ***
134125
IBP_4_2_IV0(28, "4.2", "IV0", false),
135126

136127
// Enables "streams" groups by default for new clusters (KIP-1071).
137-
//
138-
// *** THIS IS A PLACEHOLDER UNSTABLE VERSION WHICH IS USED TO DEFINE THE POINT AT WHICH ***
139-
// *** STREAMS GROUPS BECOME PRODUCTION-READY IN THE FUTURE. ITS DEFINITION ALLOWS A STREAMS ***
140-
// *** GROUPS FEATURE TO BE DEFINED IN 4.1 BUT TURNED OFF BY DEFAULT, ABLE TO BE TURNED ON ***
141-
// *** DYNAMICALLY TO TRY OUT THE EARLY ACCESS CAPABILITY. ***
142128
IBP_4_2_IV1(29, "4.2", "IV1", false);
143129

144130
// NOTES when adding a new version:

server-common/src/main/java/org/apache/kafka/server/common/ShareVersion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public enum ShareVersion implements FeatureVersion {
2424
SV_0(0, MetadataVersion.MINIMUM_VERSION, Map.of()),
2525

2626
// Version 1 enables share groups (KIP-932).
27-
// This is a preview in 4.1, and expected to be production-ready in 4.2.
27+
// This was a preview in 4.1 which required enabling explicitly.
2828
SV_1(1, MetadataVersion.IBP_4_2_IV0, Map.of());
2929

3030
public static final String FEATURE_NAME = "share.version";

0 commit comments

Comments
 (0)