Skip to content

Commit fdf9ac2

Browse files
authored
Merge ServiceLoader registrations when shading xtable-utilities (#906)
The shade plugin had no ServicesResourceTransformer, so every META-INF/services/* file was last-one-wins: whichever artifact shade processed last silently overwrote the others. Two visible consequences. The bundled jar could not read Delta sources at all, because Delta's DataSourceRegister entry lost to Spark's and sourceFormat: DELTA died with ClassNotFoundException: delta.DefaultSource despite the class being present. And only one Hadoop FileSystem registration survived, which is why xtable-hadoop-defaults.xml has to name fs.file.impl, fs.s3a.impl and the GCS classes by hand. Closes #905.
1 parent dafce0a commit fdf9ac2

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

xtable-utilities/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,7 @@
286286
<resource>META-INF/NOTICE</resource>
287287
<file>target/classes/META-INF/NOTICE-bundled</file>
288288
</transformer>
289+
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
289290
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
290291
<mainClass>org.apache.xtable.utilities.RunSync</mainClass>
291292
</transformer>

0 commit comments

Comments
 (0)