feat(datafusion): Support INSERT INTO partitioned tables
#1827
Conversation
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @CTTY for this pr!
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_insert_into_partitioned() -> Result<()> { |
There was a problem hiding this comment.
Could we move this test to newly added sqllogictests? I think we should be able to read/write now.
There was a problem hiding this comment.
I think this makes sense, I'll work on adding sqllogictests for INSERT INTO overall.
This test case still has its value as it validates the inserted data files are put under the partitioned path correctly. I'll create a tracking issue as a follow up
There was a problem hiding this comment.
I think the overall direction is to remove integration tests like this, and move them in sqllogictests. But we could delete this after we fix #1835 .
This test case still has its value as it validates the inserted data files are put under the partitioned path correctly.
I'm not convinced. Such detailed check could be done in ut of low level apis rather in integration tests.
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @CTTY for this pr!
2 participants
Which issue does this PR close?
INSERT INTOpartitioned data for DataFusion #1828insert_intoforIcebergTableProvider#1540What changes are included in this PR?
IcebergWriteExecto support partitioned dataAre these changes tested?
Added an ut