Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Aug 11, 2025

Rationale for this change

Static building for JNI build on macOS is failing in apache/arrow-java. We should avoid this in apache/arrow.

See also: apache/arrow-java#799

What changes are included in this PR?

  • Add a CI job for JNI build on macOS
  • Fix build problems for bundled AWS SDK for C++

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

⚠️ GitHub issue #47222 has been automatically assigned in GitHub to PR creator.

@kou kou changed the title GH-47222: [CI][C++] Add a CI job that use the same build options for JNI on macOS GH-47222: [CI][C++] Add a CI job that uses the same build options for JNI on macOS Aug 11, 2025
@kou kou force-pushed the ci-cpp-jni-macos branch from a269fc5 to 0518f6d Compare August 12, 2025 02:37
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: v5 has been released few hours ago.
https://github.com/actions/checkout/releases/tag/v5.0.0

Can we use checkout@v5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 uses the v5.0.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I thought If we use checkout@v5, CI will use a newer version (like v5.0.1) automatically.
Anyway, Just It was just the FYI. Please ignore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we should use SHA1 instead of tag based on the Apache policy: https://infra.apache.org/github-actions-policy.html

We can consider actions/checkout as an internal action. So we can use a tag such as v5 for actions/checkout.

But both of SHA1 and tag can be updated automatically by Dependabot like #47311 . So we can always use SHA1 without a big pain.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I understood.

@kou kou force-pushed the ci-cpp-jni-macos branch 2 times, most recently from ed3a2cd to 04dcd67 Compare August 12, 2025 04:00
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Aug 12, 2025
@kou kou force-pushed the ci-cpp-jni-macos branch 2 times, most recently from 8561998 to 31ce1ed Compare August 12, 2025 05:01
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 12, 2025
@kou kou force-pushed the ci-cpp-jni-macos branch from 31ce1ed to 368b425 Compare August 12, 2025 05:08
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 12, 2025
@kou kou force-pushed the ci-cpp-jni-macos branch from 368b425 to 59f244f Compare August 12, 2025 06:07
@kou kou force-pushed the ci-cpp-jni-macos branch from 59f244f to 3b1332b Compare August 12, 2025 21:31
@kou
Copy link
Member Author

kou commented Aug 14, 2025

+1

@kou kou merged commit cd8e677 into apache:main Aug 14, 2025
34 of 36 checks passed
@kou kou removed the awaiting change review Awaiting change review label Aug 14, 2025
@kou kou deleted the ci-cpp-jni-macos branch August 14, 2025 05:26
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cd8e677.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants