Check validity of indices in take_fixed_size_binary #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This might slow down the take kernel. A second approach I've thought of is that we keep the same iterator and apply the null mask at the end (only if the null count is > 0 for indices). @alamb Could you maye be start the benchmarks so we know the effect of this change? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
take_fixed_size_binaryDoes Not Consider NULL Indices #8947Rationale for this change
Fix incorrect behavior of take kernel for FixedSizeBinary arrays.
What changes are included in this PR?
Check that the index is valid in the iterator for the result array.
Are these changes tested?
Yes, there is a new test.
Are there any user-facing changes?
Yes, the kernel behaves correctly.