Allow OpensearchTaskHandler and OpensearchRemoteLogIO to take empty username and password

Author: topherinternational

providers/opensearch/src/airflow/providers/opensearch/log/os_task_handler.py

@@ -219,9 +219,13 @@ def _create_opensearch_client(
 ) -> OpenSearch:
     parsed_url = urlparse(_format_url(host))
     resolved_port = port if port is not None else (parsed_url.port or 9200)
+    connection_kwargs: dict[str, Any] = {
+        "hosts": [{"host": parsed_url.hostname, "port": resolved_port, "scheme": parsed_url.scheme}]
+    }
+    if username and password:
+        connection_kwargs["http_auth"] = (username, password)
     return OpenSearch(
-        hosts=[{"host": parsed_url.hostname, "port": resolved_port, "scheme": parsed_url.scheme}],
-        http_auth=(username, password),
+        **connection_kwargs,
         **os_kwargs,
     )
 

providers/opensearch/tests/unit/opensearch/log/test_os_task_handler.py

@@ -288,6 +288,22 @@ def test_client_with_patterns(self):
         )
         assert handler.index_patterns == patterns
 
+    def test_client_no_auth(self):
+        handler = OpensearchTaskHandler(
+            base_log_folder=self.local_log_location,
+            end_of_log_mark=self.end_of_log_mark,
+            write_stdout=self.write_stdout,
+            host="localhost",
+            port=9200,
+            username="",
+            password="",
+            json_format=self.json_format,
+            json_fields=self.json_fields,
+            host_field=self.host_field,
+            offset_field=self.offset_field,
+        )
+        assert "http_auth" not in handler.client.transport.kwargs
+
     @pytest.mark.db_test
     @pytest.mark.parametrize("metadata_mode", ["provided", "none", "empty"])
     def test_read(self, ti, metadata_mode):
@@ -786,6 +802,20 @@ def test_upload_returns_early_when_ti_is_none(self, tmp_path):
         log_file.write_text('{"message": "test"}\n')
         self.opensearch_io.upload(log_file, ti=None)
 
+    def test_client_no_auth(self):
+        opensearch_io = OpensearchRemoteLogIO(
+            write_to_opensearch=True,
+            write_stdout=True,
+            delete_local_copy=True,
+            host="localhost",
+            port=9200,
+            username="",
+            password="",
+            base_log_folder=self.opensearch_io.base_log_folder,
+            log_id_template="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",
+        )
+        assert "http_auth" not in opensearch_io.client.transport.kwargs
+
 
 class TestOpensearchRemoteLogIOFromConfig:
     @conf_vars(