Commit ccbc4a5
committed
Address review feedback on PR #68012
Fix the CI failures and review comments from PR #68012:
- Remove the dead module-level VersionBundle construction in
schema/versions/__init__.py that referenced names only imported
under TYPE_CHECKING, breaking the lazy cadwyn import on any access
to the module and causing NameError in ~30 task-sdk tests.
- Remove a duplicated old_ver_client fixture and import block that
had been pasted into test_task_instances.py, which triggered
mypy no-redef and ruff F811/E402 failures in Static checks.
- Use func.min(start_date) instead of ordering by TaskReschedule.id
when computing the first reschedule start date, since insertion
order does not guarantee chronological order.1 parent d55bdf8 commit ccbc4a5
3 files changed
Lines changed: 3 additions & 22 deletions
File tree
- airflow-core
- src/airflow/api_fastapi/execution_api/routes
- tests/unit/api_fastapi/execution_api/versions/v2026_06_30
- task-sdk/src/airflow/sdk/execution_time/schema/versions
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
| 302 | + | |
306 | 303 | | |
307 | 304 | | |
308 | 305 | | |
| |||
Lines changed: 2 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | 32 | | |
46 | 33 | | |
47 | 34 | | |
| |||
111 | 98 | | |
112 | 99 | | |
113 | 100 | | |
| 101 | + | |
| 102 | + | |
114 | 103 | | |
115 | 104 | | |
116 | 105 | | |
| |||
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | 23 | | |
29 | 24 | | |
30 | 25 | | |
| |||
0 commit comments