Commit ac0a428
Address review feedback on PR #68012
Fix the CI failures and review comments from PR #68012:
- Remove the dead module-level VersionBundle construction in
schema/versions/__init__.py that referenced names only imported
under TYPE_CHECKING, breaking the lazy cadwyn import on any access
to the module and causing NameError in ~30 task-sdk tests.
- Remove a duplicated old_ver_client fixture and import block that
had been pasted into test_task_instances.py, which triggered
mypy no-redef and ruff F811/E402 failures in Static checks.
- Use func.min(start_date) instead of ordering by TaskReschedule.id
when computing the first reschedule start date, since insertion
order does not guarantee chronological order.1 parent 0988540 commit ac0a428
1 file changed
Lines changed: 1 addition & 4 deletions
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
| 302 | + | |
306 | 303 | | |
307 | 304 | | |
308 | 305 | | |
| |||
0 commit comments