Fix mypy errors surfaced by the new AirflowPlugin TypedDict shapes

Author: sivavarma-x

airflow-core/src/airflow/plugins_manager.py

@@ -148,11 +148,11 @@ def _get_ui_plugins() -> tuple[list[Any], list[Any]]:
 
     seen_url_routes: dict[str, str | None] = {}
 
-    external_views: list[Any] = []
-    react_apps: list[Any] = []
+    external_views: list[ExternalViewDict] = []
+    react_apps: list[ReactAppDict] = []
     for plugin in _get_plugins()[0]:
-        external_views_to_remove = []
-        react_apps_to_remove = []
+        external_views_to_remove: list[ExternalViewDict] = []
+        react_apps_to_remove: list[ReactAppDict] = []
         for external_view in plugin.external_views:
             if not isinstance(external_view, dict):
                 log.warning(
@@ -201,10 +201,10 @@ def _get_ui_plugins() -> tuple[list[Any], list[Any]]:
             react_apps.append(react_app)
             seen_url_routes[url_route] = plugin.name
 
-        for item in external_views_to_remove:
-            plugin.external_views.remove(item)
-        for item in react_apps_to_remove:
-            plugin.react_apps.remove(item)
+        for external_view in external_views_to_remove:
+            plugin.external_views.remove(external_view)
+        for react_app in react_apps_to_remove:
+            plugin.react_apps.remove(react_app)
     return external_views, react_apps
 
 

airflow-core/tests/unit/plugins/test_plugin.py

@@ -67,7 +67,13 @@ def test(self):
 from starlette.middleware.base import BaseHTTPMiddleware
 
 # This is the class you derive to create a plugin
-from airflow.plugins_manager import AirflowPlugin
+from airflow.plugins_manager import (
+    AirflowPlugin,
+    ExternalViewDict,
+    FastAPIAppDict,
+    FastAPIRootMiddlewareDict,
+    ReactAppDict,
+)
 from airflow.task.priority_strategy import PriorityWeightStrategy
 from airflow.timetables.interval import CronDataIntervalTimetable
 
@@ -107,22 +113,22 @@ def plugin_macro():
 app = FastAPI()
 
 
-app_with_metadata = {"app": app, "url_prefix": "/some_prefix", "name": "Name of the App"}
+app_with_metadata: FastAPIAppDict = {"app": app, "url_prefix": "/some_prefix", "name": "Name of the App"}
 
 
 class DummyMiddleware(BaseHTTPMiddleware):
     async def dispatch(self, request, call_next):
         return await call_next(request)
 
 
-middleware_with_metadata = {
+middleware_with_metadata: FastAPIRootMiddlewareDict = {
     "middleware": DummyMiddleware,
     "args": [],
     "kwargs": {},
     "name": "Name of the Middleware",
 }
 
-external_view_with_metadata = {
+external_view_with_metadata: ExternalViewDict = {
     "name": "Test IFrame Airflow Docs",
     "href": "https://airflow.apache.org/",
     "icon": "https://raw.githubusercontent.com/lucide-icons/lucide/refs/heads/main/icons/plug.svg",
@@ -131,7 +137,7 @@ async def dispatch(self, request, call_next):
     "category": "browse",
 }
 
-react_app_with_metadata = {
+react_app_with_metadata: ReactAppDict = {
     "name": "Test React App",
     "bundle_url": "https://example.com/test-plugin-bundle.js",
     "icon": "https://raw.githubusercontent.com/lucide-icons/lucide/refs/heads/main/icons/plug.svg",
@@ -203,4 +209,4 @@ def on_load(self, *args, **kwargs):
 
 class AirflowTestPluginInvalid(AirflowPlugin):
     name = "test_plugin_invalid"
-    external_views = [external_view_with_invalid_destination]
+    external_views = [external_view_with_invalid_destination]  # type: ignore[list-item]  # Deliberate bad destination — exercises the /plugins runtime validation

airflow-core/tests/unit/plugins/test_plugins_manager.py

@@ -212,13 +212,16 @@ def test_should_warning_about_conflicting_url_route(self, caplog):
         class TestPluginA(AirflowPlugin):
             name = "test_plugin_a"
 
-            external_views = [{"url_route": "/test_route"}, {"wrong_view": "/no_url_route"}]
+            external_views = [
+                {"name": "A-view", "href": "/a", "url_route": "/test_route"},
+                {"name": "A-no_url_route", "href": "/b"},
+            ]
 
         class TestPluginB(AirflowPlugin):
             name = "test_plugin_b"
 
-            external_views = [{"url_route": "/test_route"}]
-            react_apps = [{"url_route": "/test_route"}]
+            external_views = [{"name": "B-view", "href": "/b", "url_route": "/test_route"}]
+            react_apps = [{"name": "B-react", "bundle_url": "/b.js", "url_route": "/test_route"}]
 
         with (
             mock_plugin_manager(plugins=[TestPluginA(), TestPluginB()]),
@@ -241,8 +244,14 @@ def test_should_warning_about_external_views_or_react_app_wrong_object(self, cap
         class TestPluginA(AirflowPlugin):
             name = "test_plugin_a"
 
-            external_views = [[{"nested_list": "/test_route"}], {"url_route": "/test_route"}]
-            react_apps = [[{"nested_list": "/test_route"}], {"url_route": "/test_route_react_app"}]
+            external_views = [
+                [{"nested_list": "/test_route"}],
+                {"name": "A-view", "href": "/a", "url_route": "/test_route"},
+            ]
+            react_apps = [
+                [{"nested_list": "/test_route"}],
+                {"name": "A-react", "bundle_url": "/a.js", "url_route": "/test_route_react_app"},
+            ]
 
         with (
             mock_plugin_manager(plugins=[TestPluginA()]),
@@ -256,8 +265,10 @@ class TestPluginA(AirflowPlugin):
             plugin_a = next(
                 plugin for plugin in plugins_manager._get_plugins()[0] if plugin.name == "test_plugin_a"
             )
-            assert plugin_a.external_views == [{"url_route": "/test_route"}]
-            assert plugin_a.react_apps == [{"url_route": "/test_route_react_app"}]
+            assert plugin_a.external_views == [{"name": "A-view", "href": "/a", "url_route": "/test_route"}]
+            assert plugin_a.react_apps == [
+                {"name": "A-react", "bundle_url": "/a.js", "url_route": "/test_route_react_app"}
+            ]
             assert len(external_views) == 1
             assert len(react_apps) == 1
 

shared/plugins_manager/src/airflow_shared/plugins_manager/plugins_manager.py

@@ -28,7 +28,7 @@
 import sys
 import types
 from pathlib import Path
-from typing import TYPE_CHECKING, Any, cast, Literal, TypedDict
+from typing import TYPE_CHECKING, Any, Literal, TypedDict, cast
 
 from typing_extensions import NotRequired