[build] Fix for #4647: Maven Central unreliable, use Antlr download page at GitHub. #4653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference alternative package containing updated antlr4 tool.
Added for testing build using new antlr4 tools.
kaby76
changed the title
kaby76
changed the title
kaby76
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4647.
Briefly, Maven Central blocks requests when bandwidth usage exceeds a threshold (https://central.sonatype.org/faq/403-error-central/#question). This can occur with builds.
The solution implemented here uses a version of the antlr4-tools that I updated to download from https://github.com/antlr/website-antlr4/tree/gh-pages/download instead of https://repo1.maven.org/maven2/org/antlr/antlr4/. In addition, the Python tool was not programmed to be very robust: with slow network communications, requests would time out. The code was updated to be more robust.
For more information on the updated antlr4-tools, see https://github.com/kaby76/antlr4-tools/tree/tools-fix-fetches and https://pypi.org/project/antlr4-tools-ken.domino/.