fix: resolve sonarcloud reliability issues

- Replace float == comparisons with pytest.approx() in tests
- Use falsy check instead of == 0.0 for amounts in GL tree rendering
- Rename shadowed parameter in _locked_refresh to avoid S1226

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: alexph-dev

qbo_cli/cli.py

@@ -355,11 +355,11 @@ def _locked_refresh(self, tokens: dict) -> str:
             fcntl.flock(lock_file, fcntl.LOCK_EX)
             try:
                 # Re-read — another process may have refreshed
-                tokens = self.load()
-                if time.time() < tokens["expires_at"] - REFRESH_MARGIN_SEC:
-                    return tokens["access_token"]
+                current = self.load()
+                if time.time() < current["expires_at"] - REFRESH_MARGIN_SEC:
+                    return current["access_token"]
 
-                new_tokens = self._do_refresh(tokens)
+                new_tokens = self._do_refresh(current)
                 self.save(new_tokens)
                 return new_tokens["access_token"]
             finally:
@@ -1003,13 +1003,13 @@ def _build_report_lines(
         section = _find_gl_section(section_idx, node["name"], node.get("id", ""))
         amt = section.total_amount if section else 0.0
         cnt = section.total_count if section else 0
-        if cnt == 0 and amt == 0.0:
+        if cnt == 0 and not amt:
             return lines
         lines.append(_pad_line(f"{node['name']} ({cnt})", _format_amount(amt, currency), prefix))
         if expanded and section:
             _append_txn_lines(section.all_transactions, currency, indent + 1, lines)
     else:
-        if subtotal_cnt == 0 and subtotal_amt == 0.0:
+        if subtotal_cnt == 0 and not subtotal_amt:
             return lines
 
         section = _find_gl_section(section_idx, node["name"], node.get("id", ""))

tests/test_live_sandbox_crud.py

@@ -319,6 +319,6 @@ def test_invoice_create_void_verify_delete():
 
         # Verify voided state — Balance should be 0
         fetched = qbo_json("get", "Invoice", inv_id)
-        assert float(fetched["Invoice"]["Balance"]) == 0.0
+        assert float(fetched["Invoice"]["Balance"]) == pytest.approx(0.0)
     finally:
         qbo("delete", "Invoice", inv_id)

tests/test_parsing.py

@@ -34,7 +34,7 @@ def test_valid_7col_row(self):
         assert txn.date == "2025-01-15"
         assert txn.txn_type == "Invoice"
         assert txn.txn_id == "5001"
-        assert txn.amount == 5000.0
+        assert txn.amount == pytest.approx(5000.0)
 
     def test_beginning_balance_skip(self):
         cols = [{"value": "Beginning Balance"}]
@@ -177,7 +177,7 @@ def test_empty_tree(self):
         idx = {}
         node = {"name": "Missing", "id": "999", "children": []}
         amt, cnt = _compute_subtotal(idx, node)
-        assert amt == 0.0
+        assert amt == pytest.approx(0.0)
         assert cnt == 0
 
 
@@ -188,15 +188,15 @@ class TestGLSectionCachedProperty:
     def test_total_amount_leaf(self):
         s = GLSection("Test", "1")
         s.direct_amount = 100.0
-        assert s.total_amount == 100.0
+        assert s.total_amount == pytest.approx(100.0)
 
     def test_total_amount_with_children(self):
         parent = GLSection("Parent", "1")
         parent.direct_amount = 50.0
         child = GLSection("Child", "2")
         child.direct_amount = 30.0
         parent.children = [child]
-        assert parent.total_amount == 80.0
+        assert parent.total_amount == pytest.approx(80.0)
 
     def test_total_count(self):
         parent = GLSection("Parent", "1")

tests/test_pure.py

@@ -213,7 +213,7 @@ def test_empty_fields(self):
         txn = GLTransaction(amount=0.0)
         d = _txn_to_dict(txn)
         assert d["date"] == ""
-        assert d["amount"] == 0.0
+        assert d["amount"] == pytest.approx(0.0)
 
 
 # ─── _collapse_tree ───────────────────────────────────────────────────────────