Merge pull request #47 from alanshurafa/contrib/alanshurafa/thoughts-uuid-dashboard

[dashboards] pro dashboard: handle UUID thought ids

Author: alanshurafa

dashboards/open-brain-dashboard-pro/app/api/audit/delete/route.ts

@@ -37,15 +37,17 @@ export async function POST(request: NextRequest) {
         { status: 400 }
       );
     }
-    const sanitized: number[] = [];
+    const UUID_RE =
+      /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
+    const sanitized: string[] = [];
     for (const raw of ids) {
-      if (!Number.isInteger(raw) || (raw as number) <= 0) {
+      if (typeof raw !== "string" || !UUID_RE.test(raw)) {
         return NextResponse.json(
-          { error: "All IDs must be positive integers" },
+          { error: "All IDs must be valid UUIDs" },
           { status: 400 }
         );
       }
-      sanitized.push(raw as number);
+      sanitized.push(raw);
     }
 
     // BL-03: Re-verify each thought actually has quality_score < 30 before deleting
@@ -57,7 +59,7 @@ export async function POST(request: NextRequest) {
       sanitized.map((id) => fetchThought(apiKey, id, excludeRestricted))
     );
 
-    const verifiedIds: number[] = [];
+    const verifiedIds: string[] = [];
     let rejected = 0;
     for (let i = 0; i < verifyResults.length; i++) {
       const r = verifyResults[i];

dashboards/open-brain-dashboard-pro/app/api/duplicates/resolve/route.ts

@@ -29,20 +29,23 @@ export async function POST(request: NextRequest) {
       thought_id_b: unknown;
     };
 
-    // BL-03: Validate IDs are positive integers, not truthy-but-wrong values
+    // BL-03: Validate IDs are UUIDs, not truthy-but-wrong values. OB1 thought
+    // ids are UUIDs, not integers.
+    const UUID_RE =
+      /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
     if (
-      !Number.isInteger(thought_id_a) ||
-      (thought_id_a as number) <= 0 ||
-      !Number.isInteger(thought_id_b) ||
-      (thought_id_b as number) <= 0
+      typeof thought_id_a !== "string" ||
+      !UUID_RE.test(thought_id_a) ||
+      typeof thought_id_b !== "string" ||
+      !UUID_RE.test(thought_id_b)
     ) {
       return NextResponse.json(
-        { error: "Both thought_id_a and thought_id_b must be positive integers" },
+        { error: "Both thought_id_a and thought_id_b must be valid UUIDs" },
         { status: 400 }
       );
     }
-    const idA = thought_id_a as number;
-    const idB = thought_id_b as number;
+    const idA = thought_id_a;
+    const idB = thought_id_b;
 
     if (idA === idB) {
       return NextResponse.json(

dashboards/open-brain-dashboard-pro/app/api/thoughts/[id]/connections/route.ts

@@ -16,9 +16,11 @@ export async function GET(
 
   const { id } = await params;
 
-  // WR-04: Validate id is a positive integer before forwarding
-  const idNum = Number(id);
-  if (!Number.isInteger(idNum) || idNum <= 0) {
+  // WR-04: Validate id is a UUID before forwarding. OB1 thought ids are UUIDs,
+  // not integers — the old positive-integer check rejected them.
+  const UUID_RE =
+    /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
+  if (!UUID_RE.test(id)) {
     return NextResponse.json({ error: "Invalid id" }, { status: 400 });
   }
 
@@ -36,7 +38,7 @@ export async function GET(
 
   try {
     const res = await fetch(
-      `${API_URL}/thought/${idNum}/connections?exclude_restricted=${excludeRestricted}&limit=20`,
+      `${API_URL}/thought/${id}/connections?exclude_restricted=${excludeRestricted}&limit=20`,
       {
         headers: {
           "x-brain-key": apiKey,

dashboards/open-brain-dashboard-pro/app/audit/page.tsx

@@ -8,7 +8,7 @@ import type { Thought, BrowseResponse } from "@/lib/types";
 
 export default function AuditPage() {
   const [data, setData] = useState<BrowseResponse | null>(null);
-  const [selected, setSelected] = useState<Set<number>>(new Set());
+  const [selected, setSelected] = useState<Set<string>>(new Set());
   const [page, setPage] = useState(1);
   const [loading, setLoading] = useState(true);
   const [showDelete, setShowDelete] = useState(false);
@@ -56,7 +56,7 @@ export default function AuditPage() {
     setPage(next);
   };
 
-  const toggleSelect = (id: number) => {
+  const toggleSelect = (id: string) => {
     setSelected((prev) => {
       const next = new Set(prev);
       if (next.has(id)) next.delete(id);

dashboards/open-brain-dashboard-pro/app/thoughts/[id]/page.tsx

@@ -24,8 +24,10 @@ export default async function ThoughtDetailPage({
   const session = await getSession();
   const excludeRestricted = !session.restrictedUnlocked;
   const { id } = await params;
-  const thoughtId = parseInt(id, 10);
-  if (isNaN(thoughtId)) notFound();
+  const UUID_RE =
+    /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
+  const thoughtId = id;
+  if (!UUID_RE.test(thoughtId)) notFound();
 
   let thought;
   try {

dashboards/open-brain-dashboard-pro/components/ConnectionsPanel.tsx

@@ -6,7 +6,7 @@ import { TypeBadge } from "./ThoughtCard";
 import { FormattedDate } from "./FormattedDate";
 
 interface Connection {
-  id: number;
+  id: string;
   type: string;
   importance: number;
   preview: string;
@@ -20,7 +20,7 @@ export function ConnectionsPanel({
   thoughtId,
   hasMetadata,
 }: {
-  thoughtId: number;
+  thoughtId: string;
   hasMetadata: boolean;
 }) {
   const [connections, setConnections] = useState<Connection[] | null>(

dashboards/open-brain-dashboard-pro/lib/api.ts

@@ -131,7 +131,7 @@ export async function fetchThoughts(
 
 export async function fetchThought(
   apiKey: string,
-  id: number,
+  id: string,
   excludeRestricted: boolean = true
 ): Promise<Thought> {
   const qs = excludeRestricted ? "" : "?exclude_restricted=false";
@@ -140,10 +140,10 @@ export async function fetchThought(
 
 export async function updateThought(
   apiKey: string,
-  id: number,
+  id: string,
   data: { content?: string; type?: string; importance?: number }
-): Promise<{ id: number; action: string; message: string }> {
-  return apiFetch<{ id: number; action: string; message: string }>(
+): Promise<{ id: string; action: string; message: string }> {
+  return apiFetch<{ id: string; action: string; message: string }>(
     apiKey,
     `/thought/${id}`,
     {
@@ -169,8 +169,8 @@ export async function fetchDuplicates(
 
 export interface DuplicateResolveResult {
   action: string;
-  survivor_id: number | null;
-  loser_id: number | null;
+  survivor_id: string | null;
+  loser_id: string | null;
   reattached: {
     reflections: number;
     thought_entities: number;
@@ -180,8 +180,8 @@ export interface DuplicateResolveResult {
 export async function resolveDuplicate(
   apiKey: string,
   params: {
-    thought_id_a: number;
-    thought_id_b: number;
+    thought_id_a: string;
+    thought_id_b: string;
     action: "keep_a" | "keep_b" | "keep_both";
   }
 ): Promise<DuplicateResolveResult> {
@@ -193,7 +193,7 @@ export async function resolveDuplicate(
 
 export async function deleteThought(
   apiKey: string,
-  id: number
+  id: string
 ): Promise<void> {
   await apiFetch<unknown>(apiKey, `/thought/${id}`, { method: "DELETE" });
 }
@@ -236,7 +236,7 @@ export async function fetchStats(
 }
 
 export interface CaptureResult {
-  thought_id: number;
+  thought_id: string;
   action: string;
   type: string;
   sensitivity_tier: string;

dashboards/open-brain-dashboard-pro/lib/types.ts

@@ -1,5 +1,5 @@
 export interface Thought {
-  id: number;
+  id: string;
   uuid?: string;
   content: string;
   type: string;
@@ -40,8 +40,8 @@ export interface StatsResponse {
 }
 
 export interface DuplicatePair {
-  thought_id_a: number;
-  thought_id_b: number;
+  thought_id_a: string;
+  thought_id_b: string;
   similarity: number;
   content_a: string;
   content_b: string;
@@ -316,7 +316,7 @@ export type AddToBrainMode = "auto" | "single" | "extract";
 
 export interface AddToBrainResult {
   path: "single" | "extract";
-  thought_id?: number;
+  thought_id?: string;
   job_id?: string;
   type?: string;
   status?: string;