Update mypy to v2.1 (#7366)

* Fix type annotation for _check_input_for_set

Author: danielhollas

pyproject.toml

@@ -245,7 +245,7 @@ notebook = [
 # https://github.com/python/typeshed?tab=readme-ov-file#package-versioning-for-third-party-stubs
 pre-commit = [
   'aiida-core[tests]',
-  'mypy~=1.19.0',
+  'mypy~=2.1.0',
   'packaging~=23.0',
   'pre-commit~=3.5',
   'sqlalchemy[mypy]~=2.0',

src/aiida/orm/nodes/data/array/trajectory.py

@@ -830,7 +830,7 @@ def collapse_into_unit_cell(point, cell):
             xmin, ymin, zmin = _x.min(), _y.min(), _z.min()
             xmax, ymax, zmax = _x.max(), _y.max(), _z.max()
 
-            _xi, _yi, _zi = np.mgrid[xmin:xmax:60j, ymin:ymax:30j, zmin:zmax:30j]  # type: ignore[misc]
+            _xi, _yi, _zi = np.mgrid[xmin:xmax:60j, ymin:ymax:30j, zmin:zmax:30j]
             coords = np.vstack([item.ravel() for item in [_xi, _yi, _zi]])
             density = kde(coords).reshape(_xi.shape)
 

src/aiida/orm/utils/links.py

@@ -176,10 +176,10 @@ def validate_link(
 
     type_source, type_target, outdegree, indegree = link_mapping[link_type]
 
-    if not isinstance(source, type_source) or not isinstance(target, type_target):
+    if not isinstance(source, type_source) or not isinstance(target, type_target):  # type: ignore[unreachable]
         raise ValueError(f'cannot add a {link_type} link from {type(source)} to {type(target)}')
 
-    if outdegree == 'unique_triple' or indegree == 'unique_triple':
+    if outdegree == 'unique_triple' or indegree == 'unique_triple':  # type: ignore[unreachable]
         # For a `unique_triple` degree we just have to check if an identical triple already exist, either in the cache
         # or stored, in which case, the new proposed link is a duplicate and thus illegal
         duplicate_link_triple = link_triple_exists(source, target, link_type, link_label, backend)

src/aiida/tools/archive/create.py

@@ -239,7 +239,7 @@ def querybuilder():
             elif isinstance(entry, orm.Computer):
                 starting_uuids[EntityTypes.COMPUTER].add(entry.uuid)
                 entity_ids[EntityTypes.COMPUTER].add(entry.pk)
-            elif isinstance(entry, orm.User):
+            elif isinstance(entry, orm.User):  # type: ignore[unreachable]
                 starting_uuids[EntityTypes.USER].add(entry.email)
                 entity_ids[EntityTypes.USER].add(entry.pk)
             else:

src/aiida/tools/graph/age_entities.py

@@ -200,7 +200,7 @@ def _check_self_and_other(self, other: Self) -> None:
         if self._identifier_type != other.identifier_type:
             raise TypeError('The two instances do not have the same identifier type!')
 
-    def _check_input_for_set(self, input_for_set: _NodeOrGroupCls | int) -> Any:
+    def _check_input_for_set(self, input_for_set: orm.Node | orm.Group | int) -> Any:
         if isinstance(input_for_set, self._aiida_cls):
             return getattr(input_for_set, self._identifier)