Replays Self-Serve Bulk Delete System #4

everettbu · 2025-07-26T19:16:11Z

Test 5

This validates both the [Working Draft](https://www.w3.org/TR/reporting-1/#concept-reports) and the [Editor's Draft](https://w3c.github.io/reporting/#concept-reports) formats. Fixes [ID-730 - Accept current and upcoming data model](https://linear.app/getsentry/issue/ID-730/accept-current-and-upcoming-data-model).

…3936)

…o 'low' (#93927)" This reverts commit 8d04522. Co-authored-by: roaga <[email protected]>

Missed in the initial commit, leading to some relevant logs being unannotated.

We have had a few tasks get killed at 10% rollout.

Also add a test, so that this doesn't happen again

Fixes DE-129 and DE-156 --------- Co-authored-by: Cursor Agent <[email protected]>

These transitions should be matching

…` (#93946) Use `project_id` on the replay record instead of the URL (where it does not always exist). --------- Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Also fixed `replay.view_html` -> `replay.view-html` --------- Co-authored-by: Michelle Zhang <[email protected]>

…948) gets `npx @typescript/native-preview` passing again

This adds mode for all things tracing. This encompasses transactions/metrics/spans. Taken from https://github.com/getsentry/sentry/blob/feeaf393deeca8b97675bff23039c6320270aab5/src/sentry/runner/commands/devserver.py#L370

The conditions associated with a DCG can change over time, and it's good if we can be completely confident that they're consistent within a given task execution.

This is unused and most regex experiments have required broader changes to ensure that regexes are evaluated in a specific order (ex: traceparent). Removing this for now to simplify the code and very slightly improve runtime performance.

relates to https://linear.app/getsentry/issue/REPLAY-418/add-error-and-user-feedback-context-to-llm

From some testing (on feedback lists of all different lengths), this prompt seems to work better. It doesn't write overly long sentences and also does a better job at "summarizing" versus just mentioning a few specific topics and leaving out others.

Just remove a couple custom Flex* classes in favor of the Flex primitive

This has been killed a few times. Refs SENTRY-42M7

…n table (#93892)  [ticket](https://linear.app/getsentry/issue/ID-156/grouping-info-remove-type-field-from-ui) The Type field in the Grouping Info section of the issue details page was redundant. This removes the Type row from all variant types while keeping the underlying data structure intact. before ![Screenshot 2025-06-20 at 12 00 54 PM](https://github.com/user-attachments/assets/97ca72da-0a52-4446-9825-cd4fcb505adf) after ![Screenshot 2025-06-20 at 11 59 29 AM](https://github.com/user-attachments/assets/a4284d2b-c9f5-442f-b010-7fe72a598e39)

### Changes Related to this PR: getsentry/sentry#93810. This is part 1 of the change, which is pulling out the new component and just adding it to the repo. Also includes some simplification of the logic in the base component. Part 2 will be replacing tables in widgets. ### Before/After There is no UI change as the table is not being used yet. There is a new story page for the component.

…93943) to prevent this issue from becoming too noisy, add a noise config

Unfortunately, 'event_data' went from being the variable for current event context to being the complete parsed data from Redis, and we continued logging it per group. That's more data than we should be logging even arguably once, let alone per group.

Co-authored-by: Abdullah Khan <[email protected]>

Adds some simple analytics to our endpoint so we can begin building a dashboard in Amplitude.

Previously, explore supported multiple y axis per chart, so each visualize supported multiple y axis. That functionality has since been removed for simplicity so update the types here to match. Keep in mind that saved queries still store them as an array so when serializing/deserializing, we still need to treat it as an array.

We'll need the `useGetTraceItemAttributeKeys` hook in other places so refactoring it so that it can exported.

- getsentry/sentry#93894 removed usage - getsentry/sentry-options-automator#4243 removed the last override

When the max segment ID is null the process fails. We should exit early since if there aren't any segments to delete there's nothing to do.

Copilot

Pull Request Overview

This PR appears to be a comprehensive refactoring and feature addition across multiple areas of the Sentry codebase, focusing on test improvements, API enhancements, and UI component updates.

Refactors test infrastructure for workflow engines and replay handling with better error handling and parameter management
Adds new table widget visualization components and feedback summary features
Updates numerous UI components to use standardized Flex layout components instead of custom styled divs

Reviewed Changes

Copilot reviewed 106 out of 106 changed files in this pull request and generated 2 comments.

File	Description
tests/	Updates test cases for workflow engines, replays, and API endpoints with improved parameter handling and validation
static/app/views/	Major refactoring of UI components to use Flex layout, adds new table widget visualization system
static/app/components/	Replaces custom styled flex containers with standardized Flex components across multiple components
src/sentry/workflow_engine/	Enhances workflow processing with better logging and slow condition handling

Copilot · 2025-07-26T19:16:50Z

tests/sentry/replays/test_project_replay_summarize_breadcrumbs.py

+    ErrorEvent,
+    get_request_data,
+)
 from sentry.replays.lib.storage import FilestoreBlob, RecordingSegmentStorageMeta


[nitpick] The import for 'mock_replay' is added but there's no clear indication of its source or purpose. Consider adding documentation or using a more specific import path.

Suggested change

from sentry.replays.lib.storage import FilestoreBlob, RecordingSegmentStorageMeta

from sentry.replays.lib.storage import FilestoreBlob, RecordingSegmentStorageMeta

# Utility for creating mock replay data in tests

Copilot · 2025-07-26T19:16:51Z

tests/sentry/api/endpoints/test_browser_reporting_collector.py

+    def assert_invalid_report_data(self, response: Response, details: dict[str, list[str]]) -> None:
+        assert response.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY
+        response_data = response.json()  # type: ignore[attr-defined]
+        assert response_data["error"] == "Invalid report data"
+        assert response_data["details"] == details


[nitpick] The helper method 'assert_invalid_report_data' could be made into a reusable test utility function rather than being defined within the test class, improving maintainability across test files.

Suggested change

def assert_invalid_report_data(self, response: Response, details: dict[str, list[str]]) -> None:

assert response.status_code == status.HTTP_422_UNPROCESSABLE_ENTITY

response_data = response.json() # type: ignore[attr-defined]

assert response_data["error"] == "Invalid report data"

assert response_data["details"] == details

from tests.sentry.utils.test_helpers import assert_invalid_report_data

armenzg and others added 30 commits June 20, 2025 12:49

fix(insights): adds referrer to Insights charts create alerts url (#9…

ba199fa

…3936)

Revert "chore(autofix): Change default automation tuning from 'off' t…

668229d

…o 'low' (#93927)" This reverts commit 8d04522. Co-authored-by: roaga <[email protected]>

fix(aci): Use contextual logger in workflow processor (#93947)

a6e22c7

Missed in the initial commit, leading to some relevant logs being unannotated.

fix(taskworker) Increase deadlines for webhook delivery (#93941)

4549d79

We have had a few tasks get killed at 10% rollout.

fix(ourlogs): Fix top events for logs (#93939)

1a81517

Also add a test, so that this doesn't happen again

feat(aci): Set ownership on detector (#93745)

37375d9

Update RightMask component background gradient (#93933)

976bb0b

Fixes DE-129 and DE-156 --------- Co-authored-by: Cursor Agent <[email protected]>

button: fix transition (#93934)

d088de3

These transitions should be matching

fix(migrations): Patch broken saved search migrations (#93944)

8a179d9

feat(replay): Add analytics to timeline zoom buttons (#93910)

a37f99f

Also fixed `replay.view_html` -> `replay.view-html` --------- Co-authored-by: Michelle Zhang <[email protected]>

ref(profiling): Move flamegraphFrameFilter types around for tsgo (#93…

38d4d58

…948) gets `npx @typescript/native-preview` passing again

feat(devservices): Add tracing mode (#93759)

78d346e

This adds mode for all things tracing. This encompasses transactions/metrics/spans. Taken from https://github.com/getsentry/sentry/blob/feeaf393deeca8b97675bff23039c6320270aab5/src/sentry/runner/commands/devserver.py#L370

feat(feedback): frontend to display summary (#93567)

5cc91e0

fix(aci): Ensure slow conditions are consistent (#93895)

084b63a

The conditions associated with a DCG can change over time, and it's good if we can be completely confident that they're consistent within a given task execution.

ref(replay): include error context in breadcrumb summary (#93669)

8167cc5

relates to https://linear.app/getsentry/issue/REPLAY-418/add-error-and-user-feedback-context-to-llm

✨ feat(scm): add environment infomation to suspect commit prs (#93025)

fd4ab7b

flex: cleanup Flex* custom styling in favor of Flex primitive (#93809)

31c51d5

Just remove a couple custom Flex* classes in favor of the Flex primitive

fix(taskworker) Extend deadlines for check_auth (#93961)

b4d3000

This has been killed a few times. Refs SENTRY-42M7

feat(detectors): Add noise config to DB Query Injection Issue Type (#…

2e992ba

…93943) to prevent this issue from becoming too noisy, add a noise config

feat(trace-eap-waterfall): Hiding some attrs (#93964)

de377a6

Co-authored-by: Abdullah Khan <[email protected]>

feat(preprod): Add analytics to the assemble endpoint (#93871)

786861a

Adds some simple analytics to our endpoint so we can begin building a dashboard in Amplitude.

ref(trace-items): Pull useGetTraceItemAttributeKeys into hook (#93739)

9f84049

We'll need the `useGetTraceItemAttributeKeys` hook in other places so refactoring it so that it can exported.

mrduncan and others added 2 commits June 20, 2025 13:20

chore(issues): Remove traceparent experiment (#93942)

c9fee3f

- getsentry/sentry#93894 removed usage - getsentry/sentry-options-automator#4243 removed the last override

fix(replay): Add handling for null max_segment_id (#93989)

ea188e2

When the max segment ID is null the process fails. We should exit early since if there aren't any segments to delete there's nothing to do.

Copilot AI review requested due to automatic review settings July 26, 2025 19:16

Copilot AI reviewed Jul 26, 2025

View reviewed changes

akshayutture-augment mentioned this pull request Nov 14, 2025

Replays Self-Serve Bulk Delete System ai-code-review-evaluations/copilot-sentry#12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replays Self-Serve Bulk Delete System #4

Replays Self-Serve Bulk Delete System #4

Uh oh!

everettbu commented Jul 26, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 26, 2025

Uh oh!

Copilot AI Jul 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

	from sentry.replays.lib.storage import FilestoreBlob, RecordingSegmentStorageMeta
	from sentry.replays.lib.storage import FilestoreBlob, RecordingSegmentStorageMeta
	# Utility for creating mock replay data in tests

Replays Self-Serve Bulk Delete System #4

Are you sure you want to change the base?

Replays Self-Serve Bulk Delete System #4

Uh oh!

Conversation

everettbu commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

everettbu commented Jul 26, 2025 •

edited

Loading