test(mcp): derive size counts dynamically in annotations test

Follow-up to CodeRabbit feedback on rohitg00#1098: hardcoding 53 and 8
duplicated contracts owned elsewhere (tool-count-consistency.test.ts
owns the 53; ESSENTIAL_TOOLS.size is the source of truth for core).
Derive total via getAllTools().length and core via ESSENTIAL_TOOLS.size,
keeping the 23/26/4 classification counts and frozen name sets
hardcoded since those are the contract this test verifies. Adds a
partition sum invariant (23+4+26 === total) that now meaningfully
catches a new tool added without classification.

Refs rohitg00#1097

Signed-off-by: AJ Alon <alexander.joel.alon@gmail.com>

Author: ahjota

test/mcp-tool-annotations.test.ts

@@ -22,6 +22,7 @@ vi.mock("../src/config.js", () => ({
 import {
   getAllTools,
   getVisibleTools,
+  ESSENTIAL_TOOLS,
   type McpToolDef,
 } from "../src/mcp/tools-registry.js";
 import { handleToolsList } from "../src/mcp/standalone.js";
@@ -63,6 +64,8 @@ const DESTRUCTIVE_TOOLS = new Set([
   "memory_slot_delete",
 ]);
 
+const TOTAL = getAllTools().length;
+
 const instantLocalFallbackProbe = vi.fn(async () => ({
   ok: false,
   status: 0,
@@ -135,15 +138,16 @@ describe("MCP tool risk annotations", () => {
     }
   });
 
-  it("every tool falls into exactly one classification (23 + 4 + 26 = 53)", () => {
+  it("every tool falls into exactly one classification (23 + 4 + 26 covers total)", () => {
     const tools = getAllTools();
-    expect(tools.length).toBe(53);
+    expect(tools.length).toBe(TOTAL);
     const counts = { "read-only": 0, destructive: 0, "state-changing": 0, invalid: 0 };
     for (const t of tools) counts[classification(t) as keyof typeof counts]++;
     expect(counts["read-only"]).toBe(23);
     expect(counts.destructive).toBe(4);
     expect(counts["state-changing"]).toBe(26);
     expect(counts.invalid).toBe(0);
+    expect(counts["read-only"] + counts.destructive + counts["state-changing"]).toBe(TOTAL);
   });
 
   it("getVisibleTools preserves annotations in every visibility mode", () => {
@@ -152,8 +156,8 @@ describe("MCP tool risk annotations", () => {
       for (const mode of ["all", "core"]) {
         process.env["AGENTMEMORY_TOOLS"] = mode;
         const visible = getVisibleTools();
-        if (mode === "all") expect(visible.length).toBe(53);
-        if (mode === "core") expect(visible.length).toBe(8);
+        if (mode === "all") expect(visible.length).toBe(TOTAL);
+        if (mode === "core") expect(visible.length).toBe(ESSENTIAL_TOOLS.size);
         for (const tool of visible) {
           expect(tool.annotations, `tool ${tool.name} lost annotations in ${mode} mode`).toBeDefined();
         }