Added methods to SkTypeface to read the actual name of the typeface family and to retrieve ttf tables#1
Open
agallero wants to merge 16 commits into
Open
Added methods to SkTypeface to read the actual name of the typeface family and to retrieve ttf tables#1agallero wants to merge 16 commits into
agallero wants to merge 16 commits into
Conversation
…amily and to retrieve ttf tables
Windows UWP Merge
- this is done in the managed code now - removes the need to change the paint instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds some methods methods to the SKTypeface class. It also fixes an issue where if the typeface didn't exist, it would not raise an error, but generate an Access violation later.
I added tests for the new methods and another for the error in case the typeface doesn't exist