CDS extractor diagnostics must use relative paths

Updates the CDS extractor source code and unit tests in order
to ensure that tool-level diagnostics only ever use relative
paths.

Author: data-douser

extractors/cds/tools/cds-extractor.ts

@@ -183,7 +183,12 @@ try {
     if (!extractorResult.success && extractorResult.error) {
       cdsExtractorLog('error', `Error running JavaScript extractor: ${extractorResult.error}`);
       if (codeqlExePath) {
-        addJavaScriptExtractorDiagnostic(sourceRoot, extractorResult.error, codeqlExePath);
+        addJavaScriptExtractorDiagnostic(
+          sourceRoot,
+          extractorResult.error,
+          codeqlExePath,
+          sourceRoot,
+        );
       }
       logExtractorStop(false, 'JavaScript extractor failed');
     } else {
@@ -223,7 +228,12 @@ try {
   if (!extractorResult.success && extractorResult.error) {
     cdsExtractorLog('error', `Error running JavaScript extractor: ${extractorResult.error}`);
     if (codeqlExePath) {
-      addJavaScriptExtractorDiagnostic(sourceRoot, extractorResult.error, codeqlExePath);
+      addJavaScriptExtractorDiagnostic(
+        sourceRoot,
+        extractorResult.error,
+        codeqlExePath,
+        sourceRoot,
+      );
     }
     logExtractorStop(false, 'JavaScript extractor failed');
   } else {
@@ -316,6 +326,7 @@ try {
       cdsFilePathsToProcess[0], // Use first file as representative
       `Compilation orchestration failed: ${String(error)}`,
       codeqlExePath,
+      sourceRoot,
     );
   }
 }
@@ -350,7 +361,12 @@ if (!extractorResult.success && extractorResult.error) {
     // Use the first CDS file as a representative file for the diagnostic
     const firstProject = Array.from(dependencyGraph.projects.values())[0];
     const representativeFile = firstProject.cdsFiles[0] || sourceRoot;
-    addJavaScriptExtractorDiagnostic(representativeFile, extractorResult.error, codeqlExePath);
+    addJavaScriptExtractorDiagnostic(
+      representativeFile,
+      extractorResult.error,
+      codeqlExePath,
+      sourceRoot,
+    );
   }
 
   logExtractorStop(false, 'JavaScript extractor failed');

extractors/cds/tools/dist/cds-extractor.bundle.js

@@ -18,10 +18,12 @@ import type { CdsDependencyGraph, CdsProject } from '../parser';
  * Add diagnostics only for tasks with `status: failed` in the {@link CdsDependencyGraph}.
  * @param dependencyGraph The dependency graph to use as the source of truth for task status
  * @param codeqlExePath Path to CodeQL executable used to add a diagnostic notification
+ * @param sourceRoot Source root directory to use for making file paths relative
  */
 function addCompilationDiagnosticsForFailedTasks(
   dependencyGraph: CdsDependencyGraph,
   codeqlExePath: string,
+  sourceRoot: string,
 ): void {
   for (const project of dependencyGraph.projects.values()) {
     for (const task of project.compilationTasks) {
@@ -38,6 +40,7 @@ function addCompilationDiagnosticsForFailedTasks(
               sourceFile,
               task.errorSummary ?? 'Compilation failed',
               codeqlExePath,
+              sourceRoot,
             );
           }
         }
@@ -191,7 +194,11 @@ export function orchestrateRetryAttempts(
     updateDependencyGraphWithRetryResults(dependencyGraph, result);
 
     // Phase 5: Add diagnostics for definitively failed tasks.
-    addCompilationDiagnosticsForFailedTasks(dependencyGraph, codeqlExePath);
+    addCompilationDiagnosticsForFailedTasks(
+      dependencyGraph,
+      codeqlExePath,
+      dependencyGraph.sourceRootDir,
+    );
 
     result.success = result.totalSuccessfulRetries > 0 || result.totalTasksRequiringRetry === 0;
   } catch (error) {

extractors/cds/tools/dist/cds-extractor.bundle.js.map

@@ -43,7 +43,7 @@ export function runJavaScriptExtractor(
   if (result.error) {
     const errorMessage = `Error running JavaScript extractor: ${result.error.message}`;
     if (codeqlExePath) {
-      addJavaScriptExtractorDiagnostic(sourceRoot, errorMessage, codeqlExePath);
+      addJavaScriptExtractorDiagnostic(sourceRoot, errorMessage, codeqlExePath, sourceRoot);
     }
     return {
       success: false,
@@ -54,7 +54,7 @@ export function runJavaScriptExtractor(
   if (result.status !== 0) {
     const errorMessage = `JavaScript extractor failed with exit code ${String(result.status)}`;
     if (codeqlExePath) {
-      addJavaScriptExtractorDiagnostic(sourceRoot, errorMessage, codeqlExePath);
+      addJavaScriptExtractorDiagnostic(sourceRoot, errorMessage, codeqlExePath, sourceRoot);
     }
     return {
       success: false,